<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2235/">https://reviewboard.asterisk.org/r/2235/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This feels very ready :-)</pre>
<br />
<p>- Matt</p>
<br />
<p>On February 24th, 2013, 3:48 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Klaus Darilion.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 3:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is continued development based on https://reviewboard.asterisk.org/r/991/ by Klaus Darillion
In that review Klaus wrote:
"This patch adds support for the Parse header (RFC 3327). This allows to record the Path (route) of incoming REGISTER requests and then reuse the learned path on outgoing out-of-dialog requests as a pre-loaded route set.
I tried to reuse as much of existing code as possible. There are several parts where I am not sure if it is implemented nice and follow chan_sip design rules (are there any?) I will post my questions as a review to myself."
---
I have added realtime support and the global flags, as well as some other minor fixes. The bulk of this code is still Klaus' work.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have this patch running with and without NAT, but not with realtime. Will test, but have also asked for testers on asterisk-dev. Need help with the LDAP schemas.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16884">ASTERISK-16884</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(381912)</span></li>
<li>/trunk/CREDITS <span style="color: grey">(381912)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(381912)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(381912)</span></li>
<li>/trunk/configs/res_ldap.conf.sample <span style="color: grey">(381912)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(381912)</span></li>
<li>/trunk/contrib/realtime/mysql/sippeers.sql <span style="color: grey">(381912)</span></li>
<li>/trunk/contrib/realtime/postgresql/realtime.sql <span style="color: grey">(381912)</span></li>
<li>/trunk/contrib/scripts/asterisk.ldap-schema <span style="color: grey">(381912)</span></li>
<li>/trunk/contrib/scripts/asterisk.ldif <span style="color: grey">(381912)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2235/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>