<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2329/">https://reviewboard.asterisk.org/r/2329/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2013, 1:48 p.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is still good to go.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Seans remark about the docs still stand.
And I wonder why we're doing insensitive by default. Switching to insensitive is always possible by extending your regex, the other way around isn't. Can't you pass a compiled regex to the regex_retrieve instead of a const char? Makes more sense to me than doing the regcomp this late. (Heck.. some other sourcery implementation might go with basic sensitive regex right now, and you wound't notice it.. until it breaks.)
Then you can wrap it with a ast_sorcery_retrieve_by_regex_string_extended_insensitive() that takes a char* all you want.
</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On February 14th, 2013, 9:52 a.m., Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2013, 9:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This change adds a retrieve_by_regex API call to sorcery. It allows searching for multiple objects using a regular expression on the object identifier. This is useful if you have related objects and want to efficiently find them.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ran unit test, confirmed happy.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/sorcery.h <span style="color: grey">(381399)</span></li>
<li>/trunk/main/sorcery.c <span style="color: grey">(381399)</span></li>
<li>/trunk/res/res_sorcery_config.c <span style="color: grey">(381399)</span></li>
<li>/trunk/res/res_sorcery_memory.c <span style="color: grey">(381399)</span></li>
<li>/trunk/tests/test_sorcery.c <span style="color: grey">(381399)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2329/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>