<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2292/">https://reviewboard.asterisk.org/r/2292/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">(1) I can still manage to mess the build up by hitting ^C during build at the wrong time.
Right now the `-include build.mak` will have `make` continue even if it cannot be found/generated. This finally culminates in a failure to build res_rtp_asterisk:
aconfigure: error: in `/usr/src/asterisk-11.x/res/pjproject':
aconfigure: error: C compiler cannot create executables
See `config.log' for more details.
[CC] res_rtp_asterisk.c -> res_rtp_asterisk.o
res_rtp_asterisk.c:53:19: fatal error: pjlib.h: No such file or directory
compilation terminated.
And after a svn-revert, make distclean, patch, I get this:
$ ./configure --enable-dev-mode
$ make -j 7
$ make 2>&1 | egrep 'error|success'
aconfigure: error: in `/usr/src/asterisk-11.x/res/pjproject':
aconfigure: error: C compiler cannot create executables
+ Asterisk has successfully been built, and +
Did aconfigure fail? Why did things build? What's going on?
Tzafrir wrote:
> I wonder if it's possible for the top-level configure script to call the
> pjproject configure script recursively (autoconf supports that).
I think that might be the way forward.
(2) distclean now stays working, so that's good.
Tzafrir wrote:
> Building a deb package involvs running 'clean', and only then 'build'
> which means distclean before configure.
You might want to add this to clarify:
--- Makefile.orig 2013-02-01 12:32:48.061100545 +0100
+++ Makefile 2013-02-01 12:33:22.243889685 +0100
@@ -328,6 +328,8 @@
_full: makeopts $(SUBDIRS) doc/full-en_US.xml $(ADDL_TARGETS)
makeopts: configure
+ @# Due to the -include above, this may fail once without consequences.
+ @# Hence we see this before running distclean on a clean directory.
@echo "****"
@echo "**** The configure script must be executed before running '$(MAKE)'."
@echo "**** Please run \"./configure\"."
</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On January 31st, 2013, 3:51 p.m., Jason Parker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review depends on the changes from https://reviewboard.asterisk.org/r/2291/
This changes the way we build pjproject. We no longer need to execute the top-level 'all' target. We can build individual libraries instead.
We should now be much more tolerant of build failures along the way.
Incidentally, in order to properly fix one of the major issues people were facing, I had to change our top-level Makefile to clean our own broken dependencies. Targets that need configure to have been run should now actually require configure to have been run.
Also removes a few weird workarounds that got added along the way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many, many builds, in varying states of completeness and cleanliness.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20815">ASTERISK-20815</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure.ac <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/common.mak <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/os-auto.mak.in <span style="color: grey">(380737)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>