<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2292/">https://reviewboard.asterisk.org/r/2292/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for finding that. Is good to go.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2292/diff/2/?file=33244#file33244line77" style="color: black; font-weight: bold; text-decoration: underline;">/branches/11/res/Makefile</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">pjproject: pjproject/build.mak</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">77</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">(</span><span class="nb">cd </span>pjproject <span class="o">&&</span> <span class="nv">CFLAGS</span><span class="o">=</span><span class="s2">"-fPIC $(_ASTCFLAGS)"</span> ./configure --build<span class="o">=</span><span class="k">$(</span>BUILD_PLATFORM<span class="k">)</span> --host<span class="o">=</span><span class="k">$(</span>HOST_PLATFORM<span class="k">)</span> --disable-floating-point --disable-sound --disable-oss --disable-speex-aec --disable-l16-codec --disable-gsm-codec --disable-g722-codec --disable-g7221-codec --disable-speex-codec --disable-ilbc-codec --disable-g711-codec<span class="o">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">16:31 <@Qwell> in res/Makefile, kill the $(_ASTCFLAGS) on the ./configure line.
</pre>
</div>
<br />
<p>- wdoekes</p>
<br />
<p>On January 31st, 2013, 3:51 p.m., Jason Parker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 3:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review depends on the changes from https://reviewboard.asterisk.org/r/2291/
This changes the way we build pjproject. We no longer need to execute the top-level 'all' target. We can build individual libraries instead.
We should now be much more tolerant of build failures along the way.
Incidentally, in order to properly fix one of the major issues people were facing, I had to change our top-level Makefile to clean our own broken dependencies. Targets that need configure to have been run should now actually require configure to have been run.
Also removes a few weird workarounds that got added along the way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many, many builds, in varying states of completeness and cleanliness.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20815">ASTERISK-20815</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/Makefile <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/aconfigure.ac <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/common.mak <span style="color: grey">(380737)</span></li>
<li>/branches/11/res/pjproject/build/os-auto.mak.in <span style="color: grey">(380737)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>