<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2292/">https://reviewboard.asterisk.org/r/2292/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 30th, 2013, 4:31 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The `make -j` problems solved by the _cleantest_* workarounds seem to be resolved by this patch indeed.
But now `make distclean` is broken:
- distclean before configure doesn't work
- distclean after configure forces a configure of pjproject
You can live with both, but it's far from pretty.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do we want to guarantee that everything will be removed, when we potentially don't have enough information (makeopts) to remove it all? My assumption when starting this was that we did not.</pre>
<br />
<p>- Jason</p>
<br />
<p>On January 25th, 2013, 1:40 p.m., Jason Parker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2013, 1:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review depends on the changes from https://reviewboard.asterisk.org/r/2291/
This changes the way we build pjproject. We no longer need to execute the top-level 'all' target. We can build individual libraries instead.
We should now be much more tolerant of build failures along the way.
Incidentally, in order to properly fix one of the major issues people were facing, I had to change our top-level Makefile to clean our own broken dependencies. Targets that need configure to have been run should now actually require configure to have been run.
Also removes a few weird workarounds that got added along the way.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Many, many builds, in varying states of completeness and cleanliness.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20815">ASTERISK-20815</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/Makefile <span style="color: grey">(380107)</span></li>
<li>/branches/11/res/Makefile <span style="color: grey">(380107)</span></li>
<li>/branches/11/res/pjproject/aconfigure <span style="color: grey">(380107)</span></li>
<li>/branches/11/res/pjproject/aconfigure.ac <span style="color: grey">(380107)</span></li>
<li>/branches/11/res/pjproject/build/common.mak <span style="color: grey">(380107)</span></li>
<li>/branches/11/res/pjproject/build/os-auto.mak.in <span style="color: grey">(380107)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2292/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>