<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2254/">https://reviewboard.asterisk.org/r/2254/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2013, 6:48 p.m., <b>Alec Davis</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the hint format should be Provider:queuename_queueattribute_agent
Queue:403_pause_Local/xyz
This would be more inline with the Queue ringing hint;
Queue:techsupport
Or the Queue_avail hint;
Queue:techsupport_avail
</pre>
</blockquote>
<p>On January 18th, 2013, 1:57 p.m., <b>p_lindheimer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Can others familiar with 'proper state naming conventions' chime in now? I'm not picky but would like an 'authoritative' decision on the naming convention sooner rather then later. The FreePBX Distro includes this patch now in the Asterisk RPM and this format is incorporated into FreePBX 2.11 so if we need to make a change it would be nice to know in advance of any final approval of the patch itself. Thanks!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There's certainly no rules I can point you to on this one. In most cases, hint names have been pretty self-evident and haven't been conveying much information beyond a device name. In this case, as Alec has pointed out, it falls more in-line with other existing queue hints to have it laid out as he has recommended.</pre>
<br />
<p>- Mark</p>
<br />
<p>On December 27th, 2012, 12:46 p.m., p_lindheimer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and p_lindheimer.</div>
<div>By p_lindheimer.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 12:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a Queue Pause Device State that allows hints to be generated and thus useful BLF buttons on phones. The format is:
qpause:qname:agent
so an example hint that could be made from this, for agent 702 (Local) in queue 434 would look like this:
exten => *46*702*434,hint,qpause:434:Local/702@from-queue/n
This has been implemented in FreePBX 2.11 (currently in beta) and is required for full functionality, it has been tested using version 11 and 10 and the patch is included on the version of Asterisk included in the FreePBX Distro for both versions 10 and 11.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested on latest versions 10 and 11 using FreePBX 2.11</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_queue.c <span style="color: grey">(378206)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2254/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>