<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2277/">https://reviewboard.asterisk.org/r/2277/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This works great, nice description in the sample config too.
Possible addition to the 'CHANGES' file since its new feature.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2277/diff/2/?file=32886#file32886line4405" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/channels/chan_skinny.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void skinny_dialer(struct skinny_subchannel *sub, int timedout)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4349</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SKINNY_DEBUG</span><span class="p">(</span><span class="n">DEBUG_SUB</span><span class="p">,</span> <span class="mi">3</span><span class="p">,</span> <span class="s">"Sub %d - Force dialing '%s'</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">sub</span><span class="o">-></span><span class="n">callid</span><span class="p">,</span> <span class="n">sub</span><span class="o">-></span><span class="n">exten</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4405</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">SKINNY_DEBUG</span><span class="p">(</span><span class="n">DEBUG_SUB</span><span class="p">,</span> <span class="mi">3</span><span class="p">,</span> <span class="s">"Sub %d - Force dialing '%s'<span class="hl"> because of %s</span></span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="n">sub</span><span class="o">-></span><span class="n">callid</span><span class="p">,</span> <span class="n">sub</span><span class="o">-></span><span class="n">exten</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">timedout</span></span><span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="s"><span class="hl">"timeout"</span></span><span class="o"><span class="hl">:</span></span><span class="s"><span class="hl">"exactmatch"</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Missed a space between timedout and ?</pre>
</div>
<br />
<p>- Brad</p>
<br />
<p>On January 20th, 2013, 3:22 p.m., wedhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Brad Latus.</div>
<div>By wedhorn.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2013, 3:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a dial softkey when the device is in DAFD. The softkey is greyed (unusable) until a possible dialplan match is entered.
Code includes updating transmit_selectsoftkeys to allow the use of a button mask.
Also add option to use # or * as a dial now button.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Several calls, behaviour as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(379583)</span></li>
<li>/trunk/configs/skinny.conf.sample <span style="color: grey">(379583)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2277/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>