<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2270/">https://reviewboard.asterisk.org/r/2270/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2013, 8:53 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2270/diff/1/?file=32711#file32711line11" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/mjordan/longcat/configs/manager.conf</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">read = system,call,log,verbose,agent,user,config,dtmf,reporting,cdr,dialplan,test</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">read = system,call,log,verbose,agent,user,config,dtmf,reporting,cdr,dialplan,test<span class="hl">,agi</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">write = system,call,agent,user,config,command,reporting,originate</pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">write = system,call,agent,user,config,command,reporting,originate<span class="hl">,agi</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How is this change related to the others?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">AsyncAgi test.
{quote}
As an added bonus: also a test that verifies AsyncAGI's 'break' command, namely that it actually breaks AsyncAGI.
{quote}</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 17th, 2013, 8:53 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2270/diff/1/?file=32746#file32746line19" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/mjordan/longcat/tests/tests.yaml</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">19</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">dir</span><span class="p-Indicator">:</span> <span class="s">'asyncagi'</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ditto.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">See previous.
Why did it get bundled with this set of tests? Because originally all of this was going to be done with AsyncAGI, until Richard pointed out that it should just be an AMI command. Since I'd already written the AsyncAGI break test, I left it in the branch and included it with the rest of tests.
I can break it out into a separate review, but the AsyncAGI break test is fairly trivial.</pre>
<br />
<p>- Matt</p>
<br />
<p>On January 8th, 2013, 3:29 p.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 3:29 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds the following tests for https://reviewboard.asterisk.org/r/2265/:
* ControlPlayback application
** Test rewind, initiated by a user (with default and non-default values) and by an AMI connection
** Test fast forward, initiated by a user (with default and non-default values) and by an AMI connection
** Test restart, initiated by a user and AMI connection
** Test stop, initiated by a user and AMI connection
** Test pause, where the playback is both paused and unpaused, initiated by a user and AMI connection
** Test a (very) nominal playback
* Playback application
** Test rewind, initiated by an AMI connection
** Test fast forward, initiated by an AMI connection
** Test a stopped playback caused by restart, initiated by an AMI connection
** Test a stopped playback caused by stop, initiated by a an AMI connection
** Test a stopped playback caused by pause, initiated by an AMI connection
** Test a (very) nominal playback
As an added bonus: also a test that verifies AsyncAGI's 'break' command, namely that it actually breaks AsyncAGI.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20882">ASTERISK-20882</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/configs/manager.conf <span style="color: grey">(3600)</span></li>
<li>/asterisk/team/mjordan/longcat/lib/python/asterisk/SimpleTestCase.py <span style="color: grey">(3600)</span></li>
<li>/asterisk/team/mjordan/longcat/lib/python/asterisk/apptest.py <span style="color: grey">(3600)</span></li>
<li>/asterisk/team/mjordan/longcat/lib/python/asterisk/asterisk.py <span style="color: grey">(3600)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/control_playback/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/nominal/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/nominal/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/playback/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/apps/tests.yaml <span style="color: grey">(3600)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/asyncagi_break.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/asyncagi/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mjordan/longcat/tests/tests.yaml <span style="color: grey">(3600)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2270/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>