<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2254/">https://reviewboard.asterisk.org/r/2254/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't see any problem with this going into trunk.
As for Asterisk 11, the best approach is probably to see if anyone has any objections on the asterisk-dev list (which this review will go out to, but sometimes people don't read all of the code reviews).</pre>
<br />
<p>- Matt</p>
<br />
<p>On December 27th, 2012, 12:46 p.m., p_lindheimer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and p_lindheimer.</div>
<div>By p_lindheimer.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2012, 12:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add a Queue Pause Device State that allows hints to be generated and thus useful BLF buttons on phones. The format is:
qpause:qname:agent
so an example hint that could be made from this, for agent 702 (Local) in queue 434 would look like this:
exten => *46*702*434,hint,qpause:434:Local/702@from-queue/n
This has been implemented in FreePBX 2.11 (currently in beta) and is required for full functionality, it has been tested using version 11 and 10 and the patch is included on the version of Asterisk included in the FreePBX Distro for both versions 10 and 11.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">tested on latest versions 10 and 11 using FreePBX 2.11</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_queue.c <span style="color: grey">(378206)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2254/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>