<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2264/">https://reviewboard.asterisk.org/r/2264/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks great.  Mark already pointed out the \param tag.</pre>
 <br />







<p>- elguero</p>


<br />
<p>On January 10th, 2013, 9:39 a.m., David Lee wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>


<p style="color: grey;"><i>Updated Jan. 10, 2013, 9:39 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This provides a JSON API by pulling in and wrapping the Jansson JSON
library[1]. The Asterisk API basically mirrors the Jansson
functionality, with a few minor tweaks:

 * Jansson provides both reference-stealing and reference-borrowing
   versions of several API&#39;s. The Asterisk API is exclusively
   reference-stealing for operations that put elements into arrays and
   objects.
 * No support for doubles, since we usually don&#39;t need that.
 * Coming along for the ride is the ast_test_check macro, which makes
   it easier to accumulate the results of several operations in a test.

 [1]: http://www.digip.org/jansson/</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Behold, extensive unit tests!</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-20888">ASTERISK-20888</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/build_tools/menuselect-deps.in <span style="color: grey">(378908)</span></li>

 <li>/trunk/configure.ac <span style="color: grey">(378908)</span></li>

 <li>/trunk/contrib/scripts/install_prereq <span style="color: grey">(378908)</span></li>

 <li>/trunk/include/asterisk/autoconfig.h.in <span style="color: grey">(378908)</span></li>

 <li>/trunk/include/asterisk/json.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/include/asterisk/test.h <span style="color: grey">(378908)</span></li>

 <li>/trunk/main/Makefile <span style="color: grey">(378908)</span></li>

 <li>/trunk/main/test.c <span style="color: grey">(378908)</span></li>

 <li>/trunk/makeopts.in <span style="color: grey">(378908)</span></li>

 <li>/trunk/res/res_json.c <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/res/res_json.exports.in <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/trunk/tests/test_json.c <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2264/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>