<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2263/">https://reviewboard.asterisk.org/r/2263/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2263/diff/1/?file=32553#file32553line4021" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/app_queue.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void rna(int rnatime, struct queue_ent *qe, char *interface, char *membername, int autopause)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">4021</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">struct</span> <span class="n">callattempt</span> <span class="o">*</span><span class="nf">wait_for_answer</span><span class="p">(</span><span class="k">struct</span> <span class="n">queue_ent</span> <span class="o">*</span><span class="n">qe</span><span class="p">,</span> <span class="k">struct</span> <span class="n">callattempt</span> <span class="o">*</span><span class="n">outgoing</span><span class="p">,</span> <span class="kt">int</span> <span class="o">*</span><span class="n">to</span><span class="p">,</span> <span class="kt">char</span> <span class="o">*</span><span class="n">digit</span><span class="p">,</span> <span class="kt">int</span> <span class="n">prebusies</span><span class="p">,</span> <span class="kt">int</span> <span class="n">caller_disconnect</span><span class="p">,</span> <span class="kt">int</span> <span class="n">forwardsallowed</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">4021</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">struct</span> <span class="n">callattempt</span> <span class="o">*</span><span class="nf">wait_for_answer</span><span class="p">(</span><span class="k">struct</span> <span class="n">queue_ent</span> <span class="o">*</span><span class="n">qe</span><span class="p">,</span> <span class="k">struct</span> <span class="n">callattempt</span> <span class="o">*</span><span class="n">outgoing</span><span class="p">,</span> <span class="kt">int</span> <span class="o">*</span><span class="n">to</span><span class="p">,</span> <span class="kt">char</span> <span class="o">*</span><span class="n">digit</span><span class="p">,</span> <span class="kt">int</span> <span class="n">prebusies</span><span class="p">,</span> <span class="kt">int</span> <span class="n">caller_disconnect</span><span class="p">,</span> <span class="kt">int</span> <span class="n">forwardsallowed</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt"><span class="hl">int</span></span><span class="hl"> </span><span class="n"><span class="hl">ringing</span></span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Be sure to update documentation.</pre>
</div>
<br />
<p>- Paul</p>
<br />
<p>On January 7th, 2013, 8 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Jan. 7, 2013, 8 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A call in the first position in the queue doesn't get maintained with prompts if a queue has periodic announcements. This small patch fixes that issue.
Whether or not it can be seen as a bug is a separate discussion, but we need it in trunk at least.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Put myself in a call queue for 20 minutes. Heard Allison and a lot of brain-washing-stupid musiconhold music. Everything worked just fine.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_queue.c <span style="color: grey">(378644)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2263/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>