<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2236/">https://reviewboard.asterisk.org/r/2236/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops. Forgot to check the ship it box on my review.</pre>
<br />
<p>- Mark</p>
<br />
<p>On December 10th, 2012, 12:23 p.m., Brent Eagles wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp and Mark Michelson.</div>
<div>By Brent Eagles.</div>
<p style="color: grey;"><i>Updated Dec. 10, 2012, 12:23 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds a peer configuration property 'ignore_requested_pref' (better name suggestions welcome of course) that causes the requested codec to be ignored when determining the preferred codec. The consequence is that Asterisk's usual efforts to prefer avoiding transcoding can be overridden on a peer-by-peer basis where appropriate. Undoubtedly a "use-with-caution" feature.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual testing performed.
Peer A -> Asterisk Host A -> Asterisk Host B (with patch applied) -> Peer B
Peer A is configured to use ulaw in Host A's sip.conf, Peer B is configured with:
disallow=all
allow=alaw
allow=ulaw
override_codecs=yes
Media from Peer A to Host A and Host A to Host B is in ulaw where the invite from Host B to Peer B specifies alaw. Media from Host B to Peer B proceeds with alaw.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(377376)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(377376)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(377376)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2236/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>