On Thu, Dec 6, 2012 at 11:37 AM, Shaun Ruffell <span dir="ltr"><<a href="mailto:sruffell@digium.com" target="_blank">sruffell@digium.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="im">As an aside, the one piece of this puzzle that is less than ideal is<br></div>
code review.<br>
<br>
- Reviewboard didn't allow me to present a change set as a series<br>
of commits easily but rather wanted all the changes squashed<br>
into a single patch on top of subversion.<br>
<br>
- Crucible didn't allow the commit messages to be reviewed along<br>
with the code change itself.<br>
<br>
- Gerrit is still in my queue to demo to see if it will solve the<br>
issue so I don't have a comment there.<br>
<br>
- Reviews by email (which I have a strong preference for for many<br>
of the same reasons it works so well for the Linux kernel) may<br>
have legal issues for a potentially dual-licensed project like<br>
Asterisk / DAHDI. One passing thought I had about this is<br>
setting up a new mailing list for DAHDI development which can be<br>
copied on 'git send-email'. But when it comes time to actually<br>
merge the code it still must be via<br>
<a href="http://issues.asterisk.org/git.asterisk.org/signed" target="_blank">issues.asterisk.org/git.asterisk.org/signed</a> tag. But I think<br>
lawyers are going to need to get involved to see if that will<br>
provide sufficient protection to Asterisk as a project.<br></blockquote><div><br></div><div>I've been using gerrit a lot lately and I like it quite a bit. Some interesting notes:</div><div><br></div><div>1) It does support posting a patch series. The UI isn't perfect for it, but it's there. I expect that to be improved in gerrit in the future given the git-centric nature of gerrit and the importance of patch series for projects using git.</div>
<div><br></div><div>Here is one example: <a href="https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/nova-compute-cells,n,z">https://review.openstack.org/#/q/project:openstack/nova+branch:master+topic:bp/nova-compute-cells,n,z</a></div>
<div><br></div><div>If you go into a specific patch, you will see a "Dependencies" section, where you can see the patch(es) that come before and/or after the one you're looking at.</div><div><br></div><div>
2) The commit message is reviewed just like the source changes in a patch. Again, take a look at any patch above as an example.</div>
<div><br></div><div>3) Gerrit has some built-in CLA checking logic that can be hooked into. <a href="http://review.openstack.org">review.openstack.org</a> uses it. You must have a CLA to be able to push changes there, which is the only path for getting patches in.</div>
<div><br></div><div>-- </div><div>Russell Bryant</div></div></div>