<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2224/">https://reviewboard.asterisk.org/r/2224/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On December 3rd, 2012, 2:08 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me.
Wouldn't mind if this went into 1.8+.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm also fine with this going into 1.8+. To me, the inability to read the screen qualifies as a bug and this change is decidedly non-invasive.</pre>
<br />
<p>- Mark</p>
<br />
<p>On December 2nd, 2012, 1:56 p.m., Tilghman Lesher wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Tilghman Lesher.</div>
<p style="color: grey;"><i>Updated Dec. 2, 2012, 1:56 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, some of the color choices used by the inline documentation are extremely difficult to read. For instance, if you use a terminal with a dark background, literals, values, and enums all present as dark blue on black, which is unreadable unless you squint at the screen, highlight the terms, or abandoning the inline documentation entirely to read about the options in a book. This is no doubt good for book sales and increases the hits to online documentation, but it's not a good choice on our part. Conversely, on screens with a light background, notes show up in yellow, which is also unreadable.
This patch fixes the problem by turning on the "bright" bit by default and turning it off when the background is indicated to be a light color (-W flag).
Note: while this patch is against trunk, I don't see any reason why this could not go into every branch from 1.8 forward, because this is a long-standing gripe, doesn't change the behavior of Asterisk, and probably would be welcomed in every corner of the Asterisk community with the possible exception of book authors, who might lose a sale or two.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looked at the output of "core show application Dial", which is the most prolifically documented application that we have, on terminals with both light backgrounds and dark backgrounds. It is completely readable in both cases after the patch. Before the patch, not so much.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/xmldoc.c <span style="color: grey">(376993)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2224/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>