<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2202/">https://reviewboard.asterisk.org/r/2202/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 21st, 2012, 1:59 p.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2202/diff/2/?file=32207#file32207line206" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/runtests.py</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">def _parse_test_yaml(self, test_dir, ast_version):</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">205</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tests</span><span class="o">.</span><span class="n">append</span><span class="p">(</span><span class="n">TestRun</span><span class="p">(</span><span class="n">path</span><span class="p">,</span> <span class="n">ast_version</span><span class="p">,</span> <span class="bp">self</span><span class="o">.</span><span class="n">options</span><span class="p">))</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">206</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">tests</span><span class="o">.</span><span class="n">append</span><span class="p">(</span><span class="n">TestRun</span><span class="p">(</span><span class="n">path</span><span class="p">,</span> <span class="n">ast_version</span><span class="p">,</span> <span class="bp">self</span><span class="o">.</span><span class="n">options</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="bp"><span class="hl">self</span></span><span class="o"><span class="hl">.</span></span><span class="n"><span class="hl">global_config</span></span><span class="p">))</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you need self.global_config, you need to set it in init or use self.test_config instead.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">self.global_config is already assigned in init. It does happen to occur in the wrong order - fixed.</pre>
<br />
<p>- Matt</p>
<br />
<p>On November 21st, 2012, 11:49 a.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Nov. 21, 2012, 11:49 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At first glance, this patch sounds stupid at best, harmful at worst. However, there is a purpose to it...
The Asterisk Test Suite has to "understand" Asterisk version numbers. It uses the version reported by the installed Asterisk to determine if a test can run. In general, this is used so that tests written against Asterisk 10 don't execute when the version of Asterisk is 1.8 (and in other similar cases). This mechanism works great for Asterisk version branches and tags (minus all of the usual shenanigans that ensue given all of the ways in which we've changed the Asterisk versioning scheme).
Trunk gets a little funky. We treat trunk as being greater then, well, everything. Fair enough.
Team branches are worse. What is mjordan-cool-branch? How do you know that branch was based off of 1.8, 10, 11, or trunk? Inspecting subversion properties for the information gets complicated, and puts some constraints on the Test Suite that we're trying to avoid. Currently, we treat team branches as being equivalent to trunk. That works for any team branch that is being used to develop new features against trunk.
This doesn't work if the team branch is actually related to 1.8, or some other version of Asterisk. If you install a team branch that is based on 1.8, all tests will be executed - including those that require features developed in later versions of Asterisk. Those tests will fail spectacularly, making it very difficult to tell if your branch has legitimate issues.
Rather then trying to manipulate the version parsing schemes (again), this patch adds an option to the test configurations that allow them to override the Asterisk version under test. In the top level test-config.yaml, define:
properties:
forced-version: 1.8.11.1
Or some other version you'd like to make the Test Suite think its running against.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used the forced-version to make the Test Suite think it was running against 1.8.0.0. Checked out a team branch based on trunk, compiled, installed, and attempted to run a ConfBridge test (confbridge_marked). Test refused to run, because it thought it was running against 1.8. Removed the forced-version; test ran.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(3508)</span></li>
<li>/asterisk/trunk/runtests.py <span style="color: grey">(3508)</span></li>
<li>/asterisk/trunk/test-config.yaml <span style="color: grey">(3508)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2202/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>