On Sun, Nov 18, 2012 at 1:34 PM, Mathis Schmieder <span dir="ltr"><<a href="mailto:mathis.schmieder@gmail.com" target="_blank">mathis.schmieder@gmail.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thanks for the advice, did just that:<div><a href="https://issues.asterisk.org/jira/browse/ASTERISK-20696" target="_blank">https://issues.asterisk.org/jira/browse/ASTERISK-20696</a><br>
</div><div class="gmail_extra"><br></div></blockquote><div><br></div><div>Some patch comments:</div><div><br></div><div>1) It looks like you have some mixed usage of tabs and spaces. Use tabs.</div><div><br></div><div>2) As we were discussing via twitter, I think it would make sense to have this happen automatically instead of as an option. You can check the codec in use by the channel and choose the sample rate based on that.</div>
<div><br></div><div>Something like ...</div><div><br></div><div> ast_format_rate(ast_channel_readformat(chan))</div><div><br></div><div>-- </div><div>Russell Bryant</div><div><br></div></div></div>