<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2198/">https://reviewboard.asterisk.org/r/2198/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 16th, 2012, 9:21 a.m., <b>elguero</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2198/diff/1/?file=32168#file32168line6667" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/channels/chan_sip.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int sip_hangup(struct ast_channel *ast)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">6667</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">p</span><span class="o">-></span><span class="n">alreadygone</span> <span class="o">&&</span> <span class="n">p</span><span class="o">-></span><span class="n">initreq</span><span class="p">.</span><span class="n">data</span> <span class="o">&&</span> <span class="o"><span class="hl">!</span></span><span class="n">ast_strlen<span class="hl">_zero</span></span><span class="p">(</span><span class="n">p</span><span class="o">-></span><span class="n">initreq</span><span class="p">.</span><span class="n">data</span><span class="o"><span class="hl">-></span></span><span class="n"><span class="hl">str</span></span><span class="p">))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">6667</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">p</span><span class="o">-></span><span class="n">alreadygone</span> <span class="o">&&</span> <span class="n">p</span><span class="o">-></span><span class="n">initreq</span><span class="p">.</span><span class="n">data</span> <span class="o">&&</span> <span class="n">ast_str<span class="hl">_str</span>len</span><span class="p">(</span><span class="n">p</span><span class="o">-></span><span class="n">initreq</span><span class="p">.</span><span class="n">data</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Curious about this change. I think the code is just a tiny, tad bit, clearer with ast_strlen_zero.</pre>
</blockquote>
<p>On November 16th, 2012, 9:27 a.m., <b>Russell Bryant</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Personally I find !strlen() just as readable as strlen_zero().
The origin of ast_strlen_zero() is that it's much more efficient to only check the first byte if all care about is if the string is empty or not. With ast_str, ast_str_strlen() is a constant time operation since the current length is stored in the ast_str struct.
The point of this particular change was to get rid of non-opaque usage of ast_str (reaching for ->str directly). To do that and still use ast_strlen_zero, it would look like:
!ast_strlen_zero(ast_str_buffer(p->initreq.data))
which is much more horrendous than:
ast_str_strlen(p->initreq.data)</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, thanks for the extra info to help me see things clearer :)
After I made my comments, it clicked in my head that this had to do with the non-opaque usage...</pre>
<br />
<p>- elguero</p>
<br />
<p>On November 16th, 2012, 6:35 a.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Nov. 16, 2012, 6:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch takes care of some low hanging str->str => ast_str_buffer(str) fruit.
According to my compiler, there are a few non-opaque ast_str string uses left after this (only in chan_sip), but they can be taken care of some other time.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(376383)</span></li>
<li>/branches/1.8/main/indications.c <span style="color: grey">(376383)</span></li>
<li>/branches/1.8/main/security_events.c <span style="color: grey">(376383)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2198/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>