<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2180/">https://reviewboard.asterisk.org/r/2180/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Nov. 6, 2012, 10:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address wdoekes' suggestion.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a series of 4 basic SIP session timer tests where Asterisk is UAS or UAC and where Asterisk or the SIPp scenario on the remote end is expected to refresh the session. There are several additional timer tests that are already planned that will cover more complex scenarios.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Asterisk 1.8, 11, and trunk.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-5054">SWP-5054</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/lib/python/asterisk/SimpleTestCase.py <span style="color: grey">(3504)</span></li>
<li>asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: grey">(3504)</span></li>
<li>asterisk/trunk/lib/python/asterisk/sipp.py <span style="color: grey">(3504)</span></li>
<li>asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: grey">(3504)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/originator.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/sipp/uas-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_refresh/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/originator.py <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/sipp/uas-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uac_teardown/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/sipp/uac-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_refresh/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/sipp/uac-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/basic_uas_teardown/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/timers/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2180/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>