<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2101/">https://reviewboard.asterisk.org/r/2101/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for the late response. Didn't get the e-mail that you updated it.
Looks good to me :)</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On September 10th, 2012, 4:50 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and rmudgett.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2012, 4:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch modifies the ast_party_redirecting structure's reason and orig_reason fields by making them structures that contain both an integer code and a string. This allows for arbitrary reasons beyond any that are predefined. This allows for a wide array of reasons to be read from the dialplan by inspecting ${REDIRECTING(reason)}.
chan_sip.c has been modified to read in the strings from a Diversion header and set the redirecting.reason.str field accordingly. Similarly, chan_sip.c has been modified to send out the reason as a quoted string in a Diversion header. chan_sip.c has also been modified to read the reason-text of a 480 response as a redirecting reason string as well.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is an accompanying test that will be going in alongside this code.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/AST-942">AST-942</a>,
<a href="https://issues.asterisk.org/jira/browse/AST-943">AST-943</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/sig_pri.c <span style="color: grey">(372318)</span></li>
<li>/trunk/funcs/func_callerid.c <span style="color: grey">(372318)</span></li>
<li>/trunk/include/asterisk/callerid.h <span style="color: grey">(372318)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(372318)</span></li>
<li>/trunk/main/callerid.c <span style="color: grey">(372318)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(372318)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(372318)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(372318)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2101/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>