<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2096/">https://reviewboard.asterisk.org/r/2096/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 5th, 2012, 2:29 a.m., <b>wdoekes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine by me.
Since you're in the vicinity, you could replace "imappasswd" with "imapfolder" in the string below.
I'd do it, but I left my commit access at home ;)
if (strcasecmp(vmu->imapfolder, "INBOX")) {
ast_test_status_update(test, "Parse failure for imappasswd option\n");
res = 1;
}
Further, I see in:
static int __messagecount(const char *context, const char *mailbox, const char *folder)
another find_user() but no free_user() of vmu.
And in leave_voicemail() only /some/ returns are preceded by a free_user(). And
more of the same in vm_authenticate().. and a pretty blatant one in
both vm_box_exists() and acf_mailbox_exists() and the list goes on.
I'll just ship-it and leave the rest for later ;)</pre>
</blockquote>
<p>On September 5th, 2012, 7:50 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test problem fixed.
You actually don't need to call free_user on a voicemail user obtained from find_user unless the first parameter passed to find_user is NULL. On the other hand, free_user should be safe to call in all cases, as a non-malloc'd voicemail user is simply passed over in free_user, and it would make the semantics of calling find_user consistent throughout app_voicemail. I didn't want to expand the patch any more than I needed to (dramatic changes in app_voicemail have a tendency to haunt the programmer)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see. That does narrow down the missing free's to only test_voicemail_msgcount().
However, apply_options_full (and friends) do strdup the emailsubject/emailbody regardless. Looks to me like a leak (albeit a lesser one) nevertheless.
</pre>
<br />
<p>- wdoekes</p>
<br />
<p>On September 4th, 2012, 9:42 p.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Sept. 4, 2012, 9:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looked to be a fairly straight forward patch (provided by the issue reporter, Filip Jenicek) - however, since the last time a memory leak was 'fixed' in app_voicemail it caused a memory corruption, I figured I'd post it up for review.
This patch fixes two memory leaks:
1. When find_user is called with NULL as its first parameter, the voicemail user returned is allocated on the heap. The inboxcount2 function uses find_user in such a fashion when counting new messages, and fails to free the resulting voicemail user object.
2. When populate_defaults is called on a voicemail user, it wipes whatever flags have been set on the object by copying over the global flags object. If the VM_ALLOCED flag was set on the voicemail user prior to doing so, that flag is removed. This leaks the voicemail user when free_user is later called.
This patch differs slightly from Filip's patch in that the populate_defaults function isn't changed to preserve the VM_ALLOCED flag, as that function affects a significant number of places in the code (and the comments for the function state that it copies over the global flags - so we probably should have expected that flags set prior to the function would be blown away). Instead, places that set the VM_ALLOCED flag do so now after calling populate_defaults.
This affected IMAP users and realtime users (and a unit test).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19155">ASTERISK-19155</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(372176)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2096/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>