<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1676/">https://reviewboard.asterisk.org/r/1676/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have committed Diff 13 plus fixing the finding in handle_ss7_linkset_mng() to the ss7_27_knk branch.
However, even with the SS7-27_libss7_trunk2_v1.diff patch from SS7-27 applied to libss7 I am still getting the message loop. You should to setup the local DAHDI spans to replicate. I described how to do that when I initially reported the problem. Local DAHDI spans do not need any hardware.
I am concerned that the libss7 trunk code is now including non-call related status information in the struct isup_call. The struct seems to be more like it should be called isup_circuit and thus should never be released unless the circuit is no longer provisioned. The got_sent_msg and timer[] members are the principle reasons that isup_call is no longer call related but circuit related.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1676/diff/12-13/?file=30930#file30930line16755" style="color: black; font-weight: bold; text-decoration: underline;">trunk/channels/chan_dahdi.c</a>
<span style="font-weight: normal;">
(Diff revisions 12 - 13)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static char *handle_ss7_linkset_mng(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16754</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o"><span class="hl">?</span></span> <span class="n">sig_ss7_cic<span class="hl">_blocking</span></span><span class="p">(</span><span class="o">&</span><span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">,</span><span class="hl"> </span><span class="n"><span class="hl">do_block</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">i</span></span><span class="p"><span class="hl">)</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16755</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k"><span class="hl">if</span></span><span class="hl"> </span><span class="p"><span class="hl">(</span></span><span class="n"><span class="hl">do_block</span></span><span class="hl"> </span><span class="o"><span class="hl"><</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="hl"> </span><span class="o"><span class="hl">&&</span></span> <span class="n">sig_ss7_<span class="hl">reset_</span>cic</span><span class="p">(</span><span class="o">&</span><span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">,</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16755</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o">:</span> <span class="n">sig_ss7_reset_cic</span><span class="p">(</span><span class="o">&</span><span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">,</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16756</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">cic</span><span class="p">,</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16756</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">cic</span><span class="p">,</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16757</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">dpc</span><span class="p">)))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16757</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">dpc</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16758</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cli</span><span class="p">(</span><span class="n">a</span><span class="o">-></span><span class="n">fd</span><span class="p">,</span> <span class="s">"Sent remote %s request on CIC %d</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span> <span class="o">-</span><span class="mi">1</span> <span class="o"><</span> <span class="n">do_block</span> <span class="o">?</span> <span class="s">"reset"</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16758</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ast_cli</span><span class="p">(</span><span class="n">a</span><span class="o">-></span><span class="n">fd</span><span class="p">,</span> <span class="s">"Sent re<span class="hl">set</span> request on CIC %d</span><span class="se">\n</span><span class="s">"</span><span class="p">,</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">16759</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="o"><span class="hl">:</span></span><span class="hl"> </span><span class="n"><span class="hl">do_block</span></span><span class="hl"> </span><span class="o"><span class="hl">?</span></span><span class="hl"> </span><span class="s"><span class="hl">"blocking"</span></span><span class="hl"> </span><span class="o"><span class="hl">:</span></span><span class="hl"> </span><span class="s"><span class="hl">"unblocking"</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">cic</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16759</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">.</span><span class="n">pvts</span><span class="p">[</span><span class="n">i</span><span class="p">]</span><span class="o">-></span><span class="n">cic</span><span class="p">);</span></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">16760</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span> <span class="k">else</span> <span class="k">if</span> <span class="p">(</span><span class="n">sig_ss7_cic_blocking</span><span class="p">(</span><span class="o">&</span><span class="n">linksets</span><span class="p">[</span><span class="n">linkset</span><span class="o">-</span><span class="mi">1</span><span class="p">].</span><span class="n">ss7</span><span class="p">,</span> <span class="n">do_block</span><span class="p">,</span> <span class="n">i</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If sig_ss7_reset_cic() doesn't fail it will then do a sig_ss7_cic_blocking() with do_block==-1.
I have fixed this in the ss7_27_knk branch.</pre>
</div>
<br />
<p>- rmudgett</p>
<br />
<p>On August 20th, 2012, 6:35 a.m., KNK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 6:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">chan_dahdi / sig_ss7 part of changes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, link setup, cli commands, bassic calls, connected line and redirection.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(371534)</span></li>
<li>trunk/channels/sig_ss7.h <span style="color: grey">(371534)</span></li>
<li>trunk/channels/sig_ss7.c <span style="color: grey">(371534)</span></li>
<li>trunk/configs/chan_dahdi.conf.sample <span style="color: grey">(371534)</span></li>
<li>trunk/configs/ss7.timers.sample <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/configure.ac <span style="color: grey">(371534)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1676/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>