<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1676/">https://reviewboard.asterisk.org/r/1676/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I took diff 11 and made the necessary changes from my findings in anticipation of getting this committed.
Unfortunately, when I tried to do some basic call testing, libss7 immediately went into an endless loop of unexpected message exchanges.
GRS ->
<- GRA
Got GRA but we didn't send GRS on CIC resetting the cic
RLC ->
Got RLC but we didn't send REL/RSC on CIC resetting the cic
<- RLC
Got RLC but we didn't send REL/RSC on CIC resetting the cic
RLC ->
Got RLC but we didn't send REL/RSC on CIC resetting the cic
<- RLC
..... both sides initiate this same message exchange to each other forever.
It appears to have something to do with the c->got_sent_msg flags and isup_handle_unexpected().
I got this with an Asterisk setup using DAHDI local spans to get a simulated back-to-back SS7 trunk. You could do this or use a back-to-back T1/E1 link.
To configure the DAHDI local spans.
In system.conf:
# Dynamic local spans for SS7 trunk (DAHDI channels 1-23 map to 25-47 respectively and sigchan 23 maps to 48)
dynamic=loc,1:0,24,0
bchan=1-23
dchan=24
dynamic=loc,1:1,24,0
bchan=25-47
dchan=48
The libss7 code from review https://reviewboard.asterisk.org/r/1653/ is now on the resurrected libss7/trunk branch. Any libss7 changes you need to do to fix the problem you can create a new review against the resurrected libss7 trunk.
The Asterisk code with my changes I was getting ready to commit is in the asterisk/team/rmudgett/ss7_27_knk branch. The ss7_27_knk branch is automerging from trunk each hour so any updated diffs for this review need to be posted as a difference between trunk and ss7_27_knk. Using a svn workspace of trunk and ss7_27_knk, the diff can be created like this:
Commands applied to the ss7_27_knk workspace:
svn pl -v
The output will have: ss7_27_knk-integrated : /trunk:1-371048
svn info
The output will have: Last Changed Rev: 371050
Applied to an unchanged trunk workspace:
Take the trunk revision from the ss7_27_knk-integrated property and the ss7_27_knk last changed revision:
svn merge URL-of-trunk@371048 URL-of-ss7_27_knk@371050
Getting Asterisk to build with these changes has a small trick needed since I want to defer recreating the ./configure script on the ss7_27_knk branch.
You need to run the ./configure script with libss7 v1.0 installed because I have already made the ./configure script tell the difference between v1.0 and the trunk libss7. Then you need to install the libss7 trunk to build Asterisk.
Note that the new libss7 Makefile optimizes the code by default. To build an unoptimized libss7 use:
make LIBSS7_OPT=
Richard</pre>
<br />
<p>- rmudgett</p>
<br />
<p>On August 6th, 2012, 10:53 a.m., KNK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>
<p style="color: grey;"><i>Updated Aug. 6, 2012, 10:53 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">chan_dahdi / sig_ss7 part of changes</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, link setup, cli commands, bassic calls, connected line and redirection.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(370748)</span></li>
<li>trunk/channels/sig_ss7.h <span style="color: grey">(370748)</span></li>
<li>trunk/channels/sig_ss7.c <span style="color: grey">(370748)</span></li>
<li>trunk/configs/chan_dahdi.conf.sample <span style="color: grey">(370748)</span></li>
<li>trunk/configs/ss7.timers.sample <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1676/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>