<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/466/">https://reviewboard.asterisk.org/r/466/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 11th, 2011, 2:07 a.m., <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't think we should have any compile-time-options or a fixed limit. If we fix this, we should have named pickup groups that can have other attributes as well in the future, possibly using ast_objects. Using bitmaps and numeric matching was something useful when CPUs had less power than today, when people have dual core in their pockets. This patch is just a short-term patch, not the solution to the problem for me.</pre>
</blockquote>
<p>On August 11th, 2011, 4:22 a.m., <b>amorsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Personally I believe that the old callgroup/pickupgroup system should be replaced completely by Pickup(@PICKUPMARK) and only remain for backwards compatibility for a while.
However, you can have multiple callgroups while one channel can only be assigned to one PICKUPMARK (fortunately Pickup handles 123@PICKUPMARK&134&PICKUPMARK). If it was possible to add multiple PICKUPMARKs somehow, it would be possible to deprecate callgroups/pickupgroups with no loss of functionality. If we can find someone to do the coding, I can probably find a sponsor for the work :)
In the meantime it is difficult to argue against code which is already written. The only objection I have is why not use long or long long? int is 32-bit on all the 64-bit systems supported by Asterisk right now, whereas long is 64-bit on those except on Windows. Long long is 64-bit everywhere even on Windows, at the cost of software emulation on 32-bit.
</pre>
</blockquote>
<p>On August 1st, 2012, 7:57 a.m., <b>Thomas Arimont</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The suggested fix on basis of named groups without a fixed limit is going to make it into Asterisk 11 now.
Please see https://reviewboard.asterisk.org/r/2043 'Extended maximum number of pickupgroups (callgroup/pickupgroup)'</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As Thomas said, the named groups in review 2043 provide a better implementation of pickup groups and meet the intent that Olle described. I'm going to go ahead and close this review out.</pre>
<br />
<p>- Matt</p>
<br />
<p>On June 22nd, 2010, 1:22 p.m., raarts wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By raarts.</div>
<p style="color: grey;"><i>Updated June 22, 2010, 1:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently the number of callgroups/pickupgroups is limited to 63, because the variable type that holds the group bits is a long long.
Here's a patch that extends this variable to an arbitrary-length (determined at compile time) int array. It currently sets the max number of groups to 1024.
It implements this for all channels, but I only tested SIP and DAHDI.
Some people might object to implementing this as an array of ints, because it introduces a loop. But I think call pickups are not done often enough for this to become a problem.
See https://issues.asterisk.org/view.php?id=16640
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch has been in our asterisk 1.2 for 3 years now without problems. I ported it over to 1.6.2 and tested it there. The patch uploaded here is against trunk which is currently being tested by a colleague of mine, but they are all basically the same patch. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_gtalk.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_jingle.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_mgcp.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_misdn.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_skinny.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(271908)</span></li>
<li>/trunk/channels/misdn_config.c <span style="color: grey">(271908)</span></li>
<li>/trunk/doc/asterisk-mib.txt <span style="color: grey">(271908)</span></li>
<li>/trunk/funcs/func_channel.c <span style="color: grey">(271908)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(271908)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(271908)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(271908)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(271908)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(271908)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/466/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>