<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1653/">https://reviewboard.asterisk.org/r/1653/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 24th, 2012, 10:59 a.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/15-16/?file=30537#file30537line1169" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/isup.c</a>
<span style="font-weight: normal;">
(Diff revisions 15 - 16)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static FUNC_SEND(range_and_status_transmit)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1168</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="p">(</span><span class="n">i</span> <span class="o">%</span> <span class="mi">8</span><span class="p">))</span> <span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1169</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">parm</span><span class="p">[</span><span class="mi">1</span> <span class="o">+</span> <span class="p">(</span><span class="n">i</span><span class="o">/</span><span class="mi">8</span><span class="p">)]</span> <span class="o">=</span> <span class="mi">0</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1170</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You only need to initialize the last octet in the bit array. Initializing all of them is a waste because you are setting each bit individually.
if (numcics) {
parm[1 + (numcics - 1) / 8] = '\0';
}
for () {
}</pre>
</blockquote>
<p>On July 24th, 2012, 11:17 a.m., <b>KNK</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Maybe i am not getting it, but the bits are only set to 1 "if (c->status[i]) " but not set to 0 otherwise.
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh. Yes, you are correct. I was missing the fact that nothing was setting bits to zero.</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 24th, 2012, 10:59 a.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/15-16/?file=30541#file30541line151" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/mtp3.h</a>
<span style="font-weight: normal;">
(Diff revisions 15 - 16)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"> rl.opc = link->master->pc;<span class="hl"> \</span></span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">151</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp"> rl.opc = link->master->pc;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you remove the semicolon too, when you use AUTORL(rl, link) you then have to put the semicolon where is is used:
AUTORL(rl, link);
The macro then looks like a function and requires a semicolon like any other function.</pre>
</blockquote>
<p>On July 24th, 2012, 11:15 a.m., <b>KNK</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually there is ; after each use and there is no need to remove it, but let me know if i should.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removing the semicolon in the macro definition makes the semicolon required where AUTORL is used. As it is, the semicolon could be omitted where it is used and still compile. Omitting the semicolon where used then makes the code look odd.</pre>
<br />
<p>- rmudgett</p>
<br />
<p>On July 24th, 2012, 8:52 a.m., KNK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>
<p style="color: grey;"><i>Updated July 24, 2012, 8:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libss7 part of the changes.
Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, link setup, cli commands, bassic calls, connected line and redirection</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SS7-21">SS7-21</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-28">SS7-28</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-33">SS7-33</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-36">SS7-36</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-38">SS7-38</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-39">SS7-39</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-40">SS7-40</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-42">SS7-42</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-43">SS7-43</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-45">SS7-45</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-46">SS7-46</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-47">SS7-47</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-48">SS7-48</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-49">SS7-49</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-51">SS7-51</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-52">SS7-52</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-53">SS7-53</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-54">SS7-54</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-7">SS7-7</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.0/libss7.h <span style="color: grey">(306)</span></li>
<li>branches/1.0/mtp2.h <span style="color: grey">(306)</span></li>
<li>branches/1.0/mtp2.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/mtp3.h <span style="color: grey">(306)</span></li>
<li>branches/1.0/mtp3.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/isup.h <span style="color: grey">(306)</span></li>
<li>branches/1.0/isup.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/parser_debug.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/ss7.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/ss7_internal.h <span style="color: grey">(306)</span></li>
<li>branches/1.0/ss7linktest.c <span style="color: grey">(306)</span></li>
<li>branches/1.0/ss7test.c <span style="color: grey">(306)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>