<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2057/">https://reviewboard.asterisk.org/r/2057/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only comment I have is that by having stringfields initialized you will use a bit of memory for no purpose (since none are defined and will never be set). If you expect that to change in the future then fine.</pre>
<br />
<p>- Joshua</p>
<br />
<p>On July 18th, 2012, 3:26 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Olle E Johansson and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 18, 2012, 3:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">oej mentioned on #asterisk-dev about a week or so ago that I had implemented this incorrectly and that I should be using the global systemname option instead. This patch does that and dispenses with the acl.conf option to set it.
The general section is left in tact for now in spite of the fact that it has no options since getting it working was mildly painful and it's pretty easily conceivable that we'll want to add general options to acl.conf in the near future. Also, if it were removed Asterisk would reject the configuration entirely if a general section were included at all... so that would also be mildly annoying.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It still compiles and generally works. It also doesn't break my tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configs/acl.conf.sample <span style="color: grey">(370226)</span></li>
<li>/trunk/main/named_acl.c <span style="color: grey">(370226)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2057/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>