<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2046/">https://reviewboard.asterisk.org/r/2046/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 17th, 2012, 2:20 p.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add this to #asterisk-dev, but making a note here too. I feel this and chan_sip ACL test could be refactored in a way to avoid duplicated code. A side from 2 line, this is virtually the same as the chan_sip runtest.</pre>
</blockquote>
<p>On July 18th, 2012, 1:27 p.m., <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I suppose I could add another subclass of TestClass.
The biggest difference between the tests aside from the originate statements of course is the evaluation of the hangup. I'll just have the addition of the expecations work the way it currently does and have the concrete test establish its own hangup evaluation function.</pre>
</blockquote>
<p>On July 18th, 2012, 2:51 p.m., <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After talking with mmichelson, I've decided I'm probably not going to do this right now since it's just these two tests being written. If we write more tests based on this stuff though, it'll definitely be worth refactoring this stuff then.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's unfortunate. -1 here.</pre>
<br />
<p>- Paul</p>
<br />
<p>On July 17th, 2012, 2:10 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson, opticron, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just like the SIP test, only Iaxy.
Tests calls made with IAX2 peers using different addresses against different ACLs. Includes tests for the following:
1. Single ACL set via permit/deny
2. Single ACL set via acl=named_acl
3. Multiple ACLs set via acl=named_acl1,named_acl2,...
4. A bad ACL set via acl=<unavailable ACL name>
5. Multiple ACLs set from a realtime SQLite3 db via acl=realtime1,realtime2,...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Ran the test itself and made sure the expected log messages appeared
2. Changed some test expectations to see how it would handle results differing from expectations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/acl.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/iax.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/res_config_sqlite3.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/realtime.sqlite3 <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/tests.yaml <span style="color: grey">(3312)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2046/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>