<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1653/">https://reviewboard.asterisk.org/r/1653/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You should not have added all the whitespace and curly brace cleanup changes to locations that you are not needing to change. They make an already large patch unnecessarily huge.
Also tabs should be set to 4 not 8.
I will continue to look at your patches.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/14/?file=30256#file30256line395" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/mtp3.c</a>
<span style="font-weight: normal;">
(Diff revision 14)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void std_test_send(struct mtp2 *link)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">395</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">mtp_error</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="s">"Event queue full</span><span class="se">\n</span><span class="s">"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Delete this line. The error has already been reported by ss7_next_empty_event().</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/14/?file=30256#file30256line508" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/mtp3.c</a>
<span style="font-weight: normal;">
(Diff revision 14)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void std_test_send(struct mtp2 *link)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">508</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ss7_error</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="s">"Event queue full!"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Delete this line. The error has already been reported by ss7_next_empty_event().</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/14/?file=30260#file30260line326" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/ss7linktest.c</a>
<span style="font-weight: normal;">
(Diff revision 14)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char *argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">313</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">ss7_add_link</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="n">ismtp2</span> <span class="o">?</span> <span class="n">SS7_TRANSPORT_DAHDIMTP2</span> <span class="o">:</span> <span class="n">SS7_TRANSPORT_DAHDIDCHAN</span><span class="p">,</span> <span class="n">fd</span><span class="p">)))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">321</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">ss7_add_link</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="n">ismtp2</span> <span class="o">?</span> <span class="n">SS7_TRANSPORT_DAHDIMTP2</span> <span class="o">:</span> <span class="n">SS7_TRANSPORT_DAHDIDCHAN</span><span class="p">,</span> <span class="n">fd</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this be:
..., fd, -1, dpc)...</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1653/diff/14/?file=30261#file30261line242" style="color: black; font-weight: bold; text-decoration: underline;">branches/1.0/ss7test.c</a>
<span style="font-weight: normal;">
(Diff revision 14)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int main(int argc, char *argv[])</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">238</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">ss7_add_link</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="n">SS7_TRANSPORT_DAHDIDCHAN</span><span class="p">,</span> <span class="n">fds</span><span class="p">[</span><span class="mi">1</span><span class="p">])))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">242</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">((</span><span class="n">ss7_add_link</span><span class="p">(</span><span class="n">ss7</span><span class="p">,</span> <span class="n">SS7_TRANSPORT_DAHDIDCHAN</span><span class="p">,</span> <span class="n">fds</span><span class="p">[</span><span class="mi">1</span><span class="p">]<span class="hl">,</span></span><span class="hl"> </span><span class="o"><span class="hl">-</span></span><span class="mi"><span class="hl">1</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="mi"><span class="hl">0</span></span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Shouldn't this be:
..., fds[1], -1, 1)...</pre>
</div>
<br />
<p>- rmudgett</p>
<br />
<p>On July 13th, 2012, 2:41 p.m., KNK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 2:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">libss7 part of the changes.
Added additional cause codes, Transmission Medium Requirement setting and connected line to CPG messages + code cleanup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiles, link setup, cli commands, bassic calls, connected line and redirection</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SS7-21">SS7-21</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-28">SS7-28</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-33">SS7-33</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-36">SS7-36</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-38">SS7-38</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-39">SS7-39</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-40">SS7-40</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-42">SS7-42</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-43">SS7-43</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-45">SS7-45</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-46">SS7-46</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-47">SS7-47</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-48">SS7-48</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-49">SS7-49</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-51">SS7-51</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-52">SS7-52</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-53">SS7-53</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-54">SS7-54</a>,
<a href="https://issues.asterisk.org/jira/browse/SS7-7">SS7-7</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.0/ss7_internal.h <span style="color: grey">(300)</span></li>
<li>branches/1.0/ss7linktest.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/libss7.h <span style="color: grey">(300)</span></li>
<li>branches/1.0/mtp2.h <span style="color: grey">(300)</span></li>
<li>branches/1.0/mtp2.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/mtp3.h <span style="color: grey">(300)</span></li>
<li>branches/1.0/mtp3.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/parser_debug.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/ss7.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/isup.c <span style="color: grey">(300)</span></li>
<li>branches/1.0/isup.h <span style="color: grey">(300)</span></li>
<li>branches/1.0/ss7test.c <span style="color: grey">(300)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>