<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2051/">https://reviewboard.asterisk.org/r/2051/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good work!</pre>
<br />
<p>- Mark</p>
<br />
<p>On July 17th, 2012, 9:06 a.m., Guenther Kelleter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and Matt Jordan.</div>
<div>By Guenther Kelleter.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 9:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add options subminexpiry and submaxexpiry in sip.conf to set limits of subscription timer independently from registration timer settings. The setting of the registration timer limits still is done by options minexpiry, maxexpiry and defaultexpiry. For backwards compatibility the setting of minexpiry and maxexpiry also is used to configure the subscription timer limits if subminexpiry and submaxexpiry are not set in sip.conf.
Bug fixed: Set registration timer limits to default values when reloading sip configuration and values are not set by configuration.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Registration and subscription checked (sip set debug).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(370151)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(370151)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(370151)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2051/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>