<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2046/">https://reviewboard.asterisk.org/r/2046/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add this to #asterisk-dev, but making a note here too. I feel this and chan_sip ACL test could be refactored in a way to avoid duplicated code. A side from 2 line, this is virtually the same as the chan_sip runtest.</pre>
<br />
<p>- Paul</p>
<br />
<p>On July 17th, 2012, 2:10 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson, opticron, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 2:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just like the SIP test, only Iaxy.
Tests calls made with IAX2 peers using different addresses against different ACLs. Includes tests for the following:
1. Single ACL set via permit/deny
2. Single ACL set via acl=named_acl
3. Multiple ACLs set via acl=named_acl1,named_acl2,...
4. A bad ACL set via acl=<unavailable ACL name>
5. Multiple ACLs set from a realtime SQLite3 db via acl=realtime1,realtime2,...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1. Ran the test itself and made sure the expected log messages appeared
2. Changed some test expectations to see how it would handle results differing from expectations.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/acl.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/extconfig.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/iax.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/modules.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/configs/ast1/res_config_sqlite3.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/realtime.sqlite3 <span style="color: grey">(UNKNOWN)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/acl_call/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/iax2/tests.yaml <span style="color: grey">(3312)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2046/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>