<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2040/">https://reviewboard.asterisk.org/r/2040/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 13th, 2012, 11:38 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It appears that SKINNY_DEBUG is only used for ast_verb calls. Consider refactoring to fit that case.</pre>
</blockquote>
<p>On July 16th, 2012, 8:59 p.m., <b>wedhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not sure how this would be refactored given the unknown number of arguments being supplied to ast_verb.</pre>
</blockquote>
<p>On July 17th, 2012, 12:59 p.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Variadic macros: http://gcc.gnu.org/onlinedocs/cpp/Variadic-Macros.html
I'd also wrap the code inside the macro in a do{...}while(0) without the trailing ';' so that the ';' is required at the end of the macro (preferred method of making macros look like normal statements in Asterisk land).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Both done.</pre>
<br />
<p>- wedhorn</p>
<br />
<p>On July 17th, 2012, 6:04 p.m., wedhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By wedhorn.</div>
<p style="color: grey;"><i>Updated July 17, 2012, 6:04 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rewrite of skinny debugging.
Debugging messages and associated controls only compiled in if configured with --enable-dev-mode
Debug messages provide more detail (including thread id) and are grouped so the user/dev can limit the type of messages displayed.
Functionally no real change to chan_skinny.
While the diff is fairly large, there are basically 3 components,
- definition of SKINNY_DEBUG at lines 134-152
- control functions at lines 3238-3374
- numerous uses of SKINNY_DEBUG throughout</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Been running for a while with --enable-dev-mode. Compiled and tested basic functionality without --enable-dev-mode.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/build_tools/cflags-devmode.xml <span style="color: grey">(369904)</span></li>
<li>trunk/channels/chan_skinny.c <span style="color: grey">(369904)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2040/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>