<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2047/">https://reviewboard.asterisk.org/r/2047/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- opticron</p>
<br />
<p>On July 13th, 2012, 4:48 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson, opticron, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated July 13, 2012, 4:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test involves configurations of acl.conf and manager.conf working in tandem. It can be sumarized into 4 tests currently and new tests can be added rather easily.
All manager users are tested against the following addresses:
127.0.0.1
127.0.0.2
127.0.0.3
127.0.0.4
test1 - An ACL specified within manger.conf using permit/deny only
The ACL is written in such a way that it will only work on address 127.0.0.1
test2 - The same ACL is used, but the manager user refers to it with acl=[aclname] instead of by manually defining it.
test3 - 3 named ACLs are used. The first denies only 127.0.0.1, the second denies only 127.0.0.3, and the third denies only 127.0.0.4
Collectively, only 127.0.0.2 is accepted.
test4 - A named ACL is used. The named ACL is not defined in acl.conf, so it is an invalid ACL and all addresses are rejected for
the user.
Like most tests I write, I imagine this one will have to be revised.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test was ran with diagnostic logs to make sure the right ACLs were passing.
Also, the expectations were changed around to make sure that failures that were anticipated to be allowed would result in test failure and succeses that were anticipated to not be allowed would also result in failures. In each case, the results changed as expected.
Lastly, the ACL rules were changed for much of the same reason. In each case, the results changed as expected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/manager/acl-login/configs/ast1/acl.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/manager/acl-login/configs/ast1/manager.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/manager/acl-login/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/manager/acl-login/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/manager/tests.yaml <span style="color: grey">(3318)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2047/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>