<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2032/">https://reviewboard.asterisk.org/r/2032/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Tilghman Lesher.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated July 12, 2012, 1:28 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In this[1] FreeBSD alloca manual, there is no reference to it returning
NULL or anything other than a hopefully usable block of memory.
[1] http://www.unix.com/man-page/FreeBSD/3/alloca/
But, I believe the gcc __builtin_alloca guarantees it won't return NULL,
but fail in more mysterious ways instead or SEGFAULT. So, I added an
ast_alloca macro that expands to that.
Does this suit you better?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">alloca and ast_strdupa shouldn't be checked for NULL. Replaced all calls to alloca() with ast_alloca() which calls the gcc __builtin_alloca() to avoid BSD semantics.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It compiles.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20125">ASTERISK-20125</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/addons/app_mysql.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/addons/chan_mobile.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/addons/res_config_mysql.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_dictate.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_directed_pickup.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_festival.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_getcpeid.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_macro.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_meetme.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_minivm.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_mixmonitor.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_osplookup.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_sms.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/apps/app_while.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/cdr/cdr_pgsql.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_alsa.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_gtalk.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_iax2.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_jingle.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_channel.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_cut.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_global.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_logic.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/funcs/func_strings.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/include/asterisk/strings.h <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/include/asterisk/utils.h <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/app.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/asterisk.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/astmm.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/callerid.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/channel.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/config.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/dsp.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/event.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/features.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/file.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/http.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/logger.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/manager.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/pbx.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/say.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/strcompat.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/tcptls.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/threadstorage.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/main/utils.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_ael.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_dundi.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_lua.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_realtime.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/pbx/pbx_spool.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/res/ael/pval.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/res/res_agi.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/res/res_config_pgsql.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/res/res_jabber.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/tests/test_linkedlists.c <span style="color: grey">(369969)</span></li>
<li>/branches/1.8/utils/extconf.c <span style="color: grey">(369969)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2032/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>