<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2024/">https://reviewboard.asterisk.org/r/2024/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2024/diff/1/?file=29889#file29889line1223" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/confbridge/conf_config_parser.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static char *complete_menu_name(const char *line, const char *word, int pos, int state)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1071</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">i</span> <span class="o">=</span> <span class="n">ao2_iterator_init</span><span class="p">(</span><span class="n">menus</span><span class="p">,</span> <span class="mi">0</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">927</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">cfg</span><span class="p">)</span> <span class="p">{</span><span class="ew"> </span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Red Blawb</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2024/diff/1/?file=29889#file29889line1587" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/confbridge/conf_config_parser.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static char *handle_cli_confbridge_show_menu(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1278</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">aco_option_register</span><span class="p">(</span><span class="o">&</span><span class="n">cfg_info</span><span class="p">,</span> <span class="s">"wait_marked"</span><span class="p">,</span> <span class="n">ACO_EXACT</span><span class="p">,</span> <span class="n">user_types</span><span class="p">,</span> <span class="s">"no"</span><span class="p">,</span> <span class="n">OPT_BOOLFLAG_T</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> <span class="n">user_profile</span><span class="p">,</span> <span class="n">flags</span><span class="p">),</span> <span class="n">USER_OPT_WAITMARKED</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1279</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">aco_option_register</span><span class="p">(</span><span class="o">&</span><span class="n">cfg_info</span><span class="p">,</span> <span class="s">"wait_marked"</span><span class="p">,</span> <span class="n">ACO_EXACT</span><span class="p">,</span> <span class="n">user_types</span><span class="p">,</span> <span class="s">"no"</span><span class="p">,</span> <span class="n">OPT_BOOLFLAG_T</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> <span class="n">user_profile</span><span class="p">,</span> <span class="n">flags</span><span class="p">),</span> <span class="n">USER_OPT_ENDMARKED</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've got yourself a typo here on line 1279. The option is "end_marked"</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2024/diff/1/?file=29889#file29889line1590" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/apps/confbridge/conf_config_parser.c</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static char *handle_cli_confbridge_show_menu(struct ast_cli_entry *e, int cmd, struct ast_cli_args *a)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1281</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">aco_option_register</span><span class="p">(</span><span class="o">&</span><span class="n">cfg_info</span><span class="p">,</span> <span class="s">"dtmf_passthrough"</span><span class="p">,</span> <span class="n">ACO_EXACT</span><span class="p">,</span> <span class="n">user_types</span><span class="p">,</span> <span class="s">"no"</span><span class="p">,</span> <span class="n">OPT_BOOLFLAG_T</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> <span class="n">user_profile</span><span class="p">,</span> <span class="n">flags</span><span class="p">),</span> <span class="n">USER_OPT_DTMF_PASS</span><span class="p">);</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1282</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">aco_option_register</span><span class="p">(</span><span class="o">&</span><span class="n">cfg_info</span><span class="p">,</span> <span class="s">"dtmf_passthrough"</span><span class="p">,</span> <span class="n">ACO_EXACT</span><span class="p">,</span> <span class="n">user_types</span><span class="p">,</span> <span class="s">"no"</span><span class="p">,</span> <span class="n">OPT_BOOLFLAG_T</span><span class="p">,</span> <span class="mi">1</span><span class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> <span class="n">user_profile</span><span class="p">,</span> <span class="n">flags</span><span class="p">),</span> <span class="n">USER_OPT_DTMF_PASS</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You've repeated the "dtmf_passthrough" option.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On July 9th, 2012, 12:41 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated July 9, 2012, 12:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This converts the confbridge app to use the new ACO API. A couple of small additions were added to the ACO API to accomodate app_confbridge:
1) A default handler was added for storing options in character arrays of a given length
2) A NoOp default handler was added so that that type= fields that are used for matching a specific type can be ignored and not cause a parsing failure
3) The aco_process_var() function was added to allow processing an individual option/value and applying it to an object. app_confbridge uses this to create user/bridge profiles with the CONFBRIDGE dialplan function.
The only behavior change that I am aware of is that the announce_only_user option (which defaulted to "yes" and used ast_true() with negative logic to clear the USER_OPT_NOONLYPERSON flag) now defaults to "yes" and evaluates using ast_false(). So basically "true" used to be default or ast_true(var->value). Now it is default or !ast_false(var->value) which is more in keeping with "yes" being the default anyway.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Created several users/bridges and verified that settings looked right with the CLI confbridge show profile/menu commands. Ran dialplan with some CONFBRIDGE() calls to verify that settings changed appropriately and that templates appeared to work.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/confbridge/conf_config_parser.c <span style="color: grey">(369815)</span></li>
<li>/trunk/apps/confbridge/include/confbridge.h <span style="color: grey">(369815)</span></li>
<li>/trunk/include/asterisk/config_options.h <span style="color: grey">(369815)</span></li>
<li>/trunk/main/config_options.c <span style="color: grey">(369815)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2024/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>