<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2025/">https://reviewboard.asterisk.org/r/2025/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 10th, 2012, 4:15 p.m., <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/2025/diff/2/?file=29942#file29942line209" style="color: black; font-weight: bold; text-decoration: underline;">trunk/funcs/func_hangupcause.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static int hangupcause_clear_exec(struct ast_channel *chan, const char *data) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">209</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ao2_callback</span><span class="p">(</span><span class="n">ast_channel_dialed_causes</span><span class="p">(</span><span class="n">chan</span><span class="p">),</span> <span class="n">OBJ_UNLINK</span> <span class="o">|</span> <span class="n">OBJ_NODATA</span> <span class="o">|</span> <span class="n">OBJ_MULTIPLE</span><span class="p">,</span> <span class="n">unlink_all_cb</span><span class="p">,</span> <span class="nb">NULL</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If you provide a NULL pointer for the callback function, then ao2_callback() will automatically match all objects in the container.
Also, OBJ_MULTIPLE will do nothing here since OBJ_NODATA renders it moot.</pre>
</blockquote>
<p>On July 10th, 2012, 4:35 p.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No. OBJ_MULTIPLE is needed. It keeps the traversal going after the first found object.</pre>
</blockquote>
<p>On July 10th, 2012, 5:02 p.m., <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There are no found objects. The callback always returns 0 and never CMP_MATCH.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, got my callbacks mixed up. It's always returning CMP_MATCH, not 0. So yeah, OBJ_MULTIPLE is required.</pre>
<br />
<p>- Mark</p>
<br />
<p>On July 9th, 2012, 3:24 p.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated July 9, 2012, 3:24 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This introduces two new functions and an application: one function to access the list of channels that have provided technology-specific cause information, one function to access the cause information itself, and a new application to clear that cause information.
This also introduces storage of and access to the per-channel translated Asterisk cause information.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Modified the current tests in the testsuite to use this new interface and they continued passing as expected.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4739">SWP-4739</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(369796)</span></li>
<li>trunk/channels/chan_iax2.c <span style="color: grey">(369796)</span></li>
<li>trunk/channels/chan_sip.c <span style="color: grey">(369796)</span></li>
<li>trunk/channels/sig_analog.c <span style="color: grey">(369796)</span></li>
<li>trunk/channels/sig_pri.c <span style="color: grey">(369796)</span></li>
<li>trunk/channels/sig_ss7.c <span style="color: grey">(369796)</span></li>
<li>trunk/funcs/func_hangupcause.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>trunk/include/asterisk/channel.h <span style="color: grey">(369796)</span></li>
<li>trunk/include/asterisk/frame.h <span style="color: grey">(369796)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(369796)</span></li>
<li>trunk/main/channel_internal_api.c <span style="color: grey">(369796)</span></li>
<li>trunk/main/rtp_engine.c <span style="color: grey">(369796)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2025/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>