<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1767/">https://reviewboard.asterisk.org/r/1767/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, not seen this review in a time.
Few corrected patch in the trunk at rev 369602/369603.
Just return by negative return value in ooh323 threads handlers in not a way due to per thread handler we must drop his thread from the list of idle threads, per select thread from list routine we must create new one.
</pre>
<br />
<p>- may213</p>
<br />
<p>On February 23rd, 2012, 9:20 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and may213.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated Feb. 23, 2012, 9:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I spend sometime cleaning up the compiler warnings, some big issues revolve around the fact that read() and write() return values are ignored. Not safe from what I read. Any suggestions / recommendations if I have handled it right?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">compiling testing on development box.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.8/addons/ooh323c/src/memheap.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323c/src/ooCapability.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323c/src/ooSocket.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323c/src/ooTimer.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323c/src/ooq931.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323c/src/perutil.c <span style="color: grey">(356432)</span></li>
<li>branches/1.8/addons/ooh323cDriver.c <span style="color: grey">(356432)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1767/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>