<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2005/">https://reviewboard.asterisk.org/r/2005/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 27th, 2012, 11:19 a.m., <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm giving a "ship it" due to the testing you said you've done. I'd feel better if there were unit tests added to ensure that SDP is parsed and generated properly.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Agreed, I think also adding unit tests before 'ship it' would be acceptable here.</pre>
<br />
<p>- Paul</p>
<br />
<p>On June 27th, 2012, 7:52 a.m., Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 27, 2012, 7:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds to the format attribute interface two methods used to parse and generate SDP for formats. It also adds two format attribute modules - one for H.263 and one for H.264. The SDP logic for CELT and SILK have also been moved to their respective format attribute modules.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Performed heavy testing of H.263 and H.264 format attribute modules using various softphones and different scenarios.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(368849)</span></li>
<li>/trunk/include/asterisk/format.h <span style="color: grey">(368849)</span></li>
<li>/trunk/main/format.c <span style="color: grey">(368849)</span></li>
<li>/trunk/main/translate.c <span style="color: grey">(368849)</span></li>
<li>/trunk/res/res_format_attr_celt.c <span style="color: grey">(368849)</span></li>
<li>/trunk/res/res_format_attr_h263.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_format_attr_h264.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_format_attr_silk.c <span style="color: grey">(368849)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2005/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>