<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1950/">https://reviewboard.asterisk.org/r/1950/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson, rmudgett, and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated May 25, 2012, 2:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should be the last set of programming changes. This review's diff file includes uncommitted changes to dahdi+iax and some other stuff that may be covered by the phase 3 review, but focus should stay on the four things mentioned.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Each channel driver was tested to make sure log messages made within related threads would bind properly and the specific channel drivers would also get the right callids referenced. Bridging api was tested via the confbridge application, and in each case the bridge threads bind to the callid of the channel that started the bridge. Autoservice was tested via the system dialplan application and threads created by it were similarly bound based on the callid of the channel that started the autoservice.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_agent.c <span style="color: grey">(367420)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(367420)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(367420)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(367420)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(367420)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(367420)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(367420)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(367420)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(367420)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(367420)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1950/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>