<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1926/">https://reviewboard.asterisk.org/r/1926/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I went through the scenarios presented and everything seems to be in order.</pre>
<br />
<p>- opticron</p>
<br />
<p>On May 17th, 2012, 4:45 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, Jason Parker and Matt Jordan.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated May 17, 2012, 4:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, see https://reviewboard.asterisk.org/r/1925 for an explanation of the "send to voicemail" Digium phones feature and how it is implemented.
This tests three scenarios.
1) A called phone forwards call to voicemail.
2) On an established call, the calling party blind transfers the called party to voicemail.
3) On an established call, the called party blind transfers the calling party to voicemail.
In all three cases, the tests' passing is based on REDIRECTING(reason) evaluating to "send_to_vm" when the call is forwarded/transferred.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tests all passed when combined with the Asterisk changes at https://reviewboard.asterisk.org/r/1925</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/sipp/uac-blind-transfer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/sipp/uas.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/sipp/uac-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/sipp/uas-blind-transfer.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/sipp/uac.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/sipp/uas-redir.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/tests.yaml <span style="color: grey">(3225)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1926/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>