<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1922/">https://reviewboard.asterisk.org/r/1922/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1922/diff/2/?file=27985#file27985line12538" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/apps/app_voicemail.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void read_password_from_file(const char *secretfn, char *password, int passwordlen) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12530</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_config</span> <span class="o">*</span><span class="n">conf</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12538</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_config</span> <span class="o">*</span><span class="n">conf</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="nb"><span class="hl">NULL</span></span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12531</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_category</span> <span class="o">*</span><span class="n">cat</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12539</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_category</span> <span class="o">*</span><span class="n">cat</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="nb"><span class="hl">NULL</span></span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12532</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_variable</span> <span class="o">*</span><span class="n">var</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12540</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">struct</span> <span class="n">ast_variable</span> <span class="o">*</span><span class="n">var</span><span class="hl"> </span><span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="nb"><span class="hl">NULL</span></span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This seems unnecessary.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1922/diff/2/?file=27985#file27985line12547" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/apps/app_voicemail.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void read_password_from_file(const char *secretfn, char *password, int passwordlen) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">12538</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="p">(</span><span class="n">cat</span><span class="o"><span class="hl">=</span></span><span class="n">ast_category_new</span><span class="p">(</span><span class="s">"general"</span><span class="p">,</span><span class="s">""</span><span class="p">,</span><span class="mi">1</span><span class="p">)))</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12547</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="p">(</span><span class="n">cat</span> <span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n">ast_category_new</span><span class="p">(</span><span class="s">"general"</span><span class="p">,</span><span class="s">""</span><span class="p">,</span><span class="mi">1</span><span class="p">)))</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since you're changing the spacing here anyway, you might as well ad spaces around the commas.</pre>
</div>
<br />
<p>- Mark</p>
<br />
<p>On May 16th, 2012, 11:38 a.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, otherwiseguy, rmudgett, and opticron.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated May 16, 2012, 11:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes a number of memory leaks in core modules (and a few modules that are extended support, but were easy to fix) that were found by a static analysis tool. A brief summary of the changes:
* app_minivm: free ast_str objects on off nominal paths
* app_page: free the ast_dial object if the requested channel technology cannot be appended to the dialing structure
* app_queue: if a penalty rule failed to match any existing rule list names, the created rule would not be inserted and its memory would be leaked
* app_read: dispose of the created silence detector in the presence of off nominal circumstances
* app_voicemail: dispose of an allocated unique ID field for MWI event un-subscribe requests in off nominal paths; dispose of configuration objects when using the secret.conf option
* chan_dahdi: dispose of the allocated frame produced by ast_dsp_process
* chan_iax2: properly unref peer in CLI command "iax2 unregister"
* chan_sip: dispose of the allocated frame produced by sip_rtp_read's call of ast_dsp_process; free memory in parse unit tests
* func_dialgroup: properly deref ao2 object grhead in nominal path of dialgroup_read
* func_odbc: free resultset in off nominal paths of odbc_read
* cli: free match_list in off nominal paths of CLI match completion
* config: free comment_buffer/list_buffer when configuration file load is unchanged; free the same buffers any time they were created and config files were processed
* data: free XML nodes in various places
* enum: free context buffer in off nominal paths
* features: free ast_call_feature in off nominal paths of applicationmap config processing
* netsock2: users of ast_sockaddr_resolve pass in an ast_sockaddr struct that is allocated by the method. Failures in ast_sockaddr_resolve could result in the users of the method not knowing whether or not the buffer was allocated. The method will now not allocate the ast_sockaddr struct if it will return failure.
* pbx: cleanup hash table traversals in off nominal paths; free ignore pattern buffer if it already exists for the specified context
* xmldoc: cleanup various nodes when we no longer need them
* main/editline: various cleanup of pointers not being freed before being assigned to other memory, cleanup along off nominal paths
* menuselect/mxml: cleanup of value buffer for an attribute when that attribute did not specify a value
* res_calendar*: responses are allocated via the various *_request method returns and should not be allocated in the various write_event methods; ensure attendee buffer is freed if no data exists in the parsed node; ensure that calendar objects are de-ref'd appropriately
* res_jabber: free buffer in off nominal path
* res_musiconhold: close the DIR* object in off nominal paths
* res_rtp_asterisk: if we run out of ports, close the rtp socket object and free the rtp object
* res_srtp: if we fail to create the session in libsrtp, destroy the temporary ast_srtp object</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19665">ASTERISK-19665</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/res/res_rtp_asterisk.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_musiconhold.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_jabber.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_calendar_icalendar.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_calendar_caldav.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_calendar_exchange.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_calendar.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/xmldoc.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/netsock2.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/pbx.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/features.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/enum.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/editline/tokenizer.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/editline/term.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/editline/readline.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/data.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/cli.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/main/config.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/funcs/func_odbc.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/funcs/func_dialgroup.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/channels/sip/config_parser.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/channels/chan_iax2.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/channels/chan_dahdi.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/apps/app_record.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/apps/app_queue.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/apps/app_page.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/apps/app_minivm.c <span style="color: grey">(366661)</span></li>
<li>/branches/1.8/res/res_srtp.c <span style="color: grey">(366661)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1922/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>