<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1926/">https://reviewboard.asterisk.org/r/1926/</a>
     </td>
    </tr>
   </table>
   <br />








<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On May 17th, 2012, 12:15 p.m., <b>Matt Jordan</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/1926/diff/2/?file=28042#file28042line8" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/test-config.yaml</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>

  </tr>
 </tbody>




 
 



 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">8</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="l-Scalar-Plain">properties</span><span class="p-Indicator">:</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="l-Scalar-Plain">dependencies</span><span class="p-Indicator">:</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">10</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">app</span> <span class="p-Indicator">:</span> <span class="s">&#39;sipp&#39;</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">11</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="l-Scalar-Plain">tags</span><span class="p-Indicator">:</span></pre></td>
  </tr>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">12</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span class="p-Indicator">-</span> <span class="l-Scalar-Plain">SIP</span></pre></td>
  </tr>

 </tbody>

</table>

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This needs some version tags of some sort.  This would apply to your other tests in here as well.</pre>
 </blockquote>





</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Any guidance on what sort of version tags to add? What is the current method of indicating that I want this to run for all certified Asterisk branches from 1.8.11 forward, and for 10-digiumphones, and for Asterisk 11, but not for vanilla 1.8 or vanilla 10?</pre>
<br />




<p>- Mark</p>


<br />
<p>On May 17th, 2012, 10:10 a.m., Mark Michelson wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers, Jason Parker and Matt Jordan.</div>
<div>By Mark Michelson.</div>


<p style="color: grey;"><i>Updated May 17, 2012, 10:10 a.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, see https://reviewboard.asterisk.org/r/1925 for an explanation of the &quot;send to voicemail&quot; Digium phones feature and how it is implemented.

This tests three scenarios.

1) A called phone forwards call to voicemail.
2) On an established call, the calling party blind transfers the called party to voicemail.
3) On an established call, the called party blind transfers the calling party to voicemail.

In all three cases, the tests&#39; passing is based on REDIRECTING(reason) evaluating to &quot;send_to_vm&quot; when the call is forwarded/transferred.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The tests all passed when combined with the Asterisk changes at https://reviewboard.asterisk.org/r/1925</pre>
  </td>
 </tr>
</table>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/sipp/uac-blind-transfer.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/sipp/uas.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uac/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/sipp/uac-no-hangup.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/sipp/uas-blind-transfer.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/blind_transfer_uas/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/configs/ast1/sip.conf <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/run-test <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/sipp/uac.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/sipp/uas-redir.xml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/call_forward/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/redirecting_reason/tests.yaml <span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/team/mmichelson/phone-testsuite/tests/channels/SIP/tests.yaml <span style="color: grey">(3225)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1926/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>