<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1904/">https://reviewboard.asterisk.org/r/1904/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In my view, this doesn't actually add any value to what's already there.
The problem with a change like this is that if you're really only interested in STUN messages, then you can't help but also either get a bunch of unrelated verbose messages or a bunch of unrelated debug messages as well. In either case, you have to issue two commands (setting the core debug level high enough and setting stun debug on, or setting the core verbose level high enough and setting stun debug on) in order to actually see STUN debug messages.
The best way to change this is to add a dynamic log level for STUN debug messages. When stun debug is set on, you enable the log level. When stun debug is turned off, you disable the log level. Then the stun debug messages are logged to the "stun" or "STUN" log instead of debug or verbose.</pre>
<br />
<p>- Mark</p>
<br />
<p>On May 7th, 2012, 3:52 p.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated May 7, 2012, 3:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently we use ast_verbose() for stun debug messages. Since debug != verbose, this patch fixes that.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">local development box
*CLI> stun set debug on
<confirmed debug message logged>
*CLI> stun set debug off</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/main/stun.c <span style="color: grey">(365563)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1904/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>