<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1905/">https://reviewboard.asterisk.org/r/1905/</a>
     </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By jrose.</div>


<p style="color: grey;"><i>Updated May 8, 2012, 3:03 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some Tilghman suggestions.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Makes corrections for a number of unchecked return reports from Coverity and marks a handful of others as being ignorable (because the return seems genuinely inconsequential for these cases).  There are a couple oddities that might need a second look.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Testing done depends on the particular issue that was being poked at. In some cases, it was as simple as a snap judgement to add a warning. In a couple others, I would test what would happen as a consequence of an unanticipated return.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-19658">ASTERISK-19658</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/apps/app_queue.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/apps/app_voicemail.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/channels/chan_iax2.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/channels/iax2-provision.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/channels/sig_analog.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/funcs/func_devstate.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/funcs/func_lock.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/acl.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/asterisk.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/db.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/features.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/pbx.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/main/xmldoc.c <span style="color: grey">(365473)</span></li>

 <li>/branches/1.8/res/ael/ael.flex <span style="color: grey">(365473)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1905/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>