<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1887/">https://reviewboard.asterisk.org/r/1887/</a>
</td>
</tr>
</table>
<br />
<p>On April 27th, 2012, 10:55 a.m., <b>Leif Madsen</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And further to the note, is there really no way to have such dependency on the announcement length having such an adverse effect to all the queue positions being announced? That is a really awkward way of having to handle things. I can imagine someone wanting to adjust the announcements dynamically through the Record() application so that they can update announcements, hold times etc...
I really don't like the dependency on the file length and the adjustment of the periodic announce values to provide a sane experience to the caller.</pre>
</blockquote>
<p>On April 29th, 2012, 4:11 a.m., <b>Olle E Johansson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the feedback, Leif.
If you can find funding I'm sure we can find a way. For this customer, this is acceptable. And I'd rather document this than just let it slip by. Isn't that better?
/O</pre>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I disagree that's better. Doing it right and giving the general community an experience that makes sense is important. There are so many things in Asterisk that were little one offs to fix a particular persons issue and then not cleaned up prior to merge, that you end up having to document around things, or the experience continuing changes over and over again. I think Asterisk has gone far enough that we should be doing it right, not just doing it for the sake of doing it.
I personally would not be comfortable with the feature going in as-is. If someone else in the community needs to finish the feature up so it works in a manner that many will expect, then so be it. If you need to continue supporting this as-is out of band for your customer, then so be that as well.</pre>
<br />
<p>- Leif</p>
<br />
<p>On April 26th, 2012, 9:42 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated April 26, 2012, 9:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Today, when a prompt is being played to a call waiting in the queue and an agent becomes available, the agent will not get the call until the prompt is finished. Both customer and agent is kept waiting.
With this rather big piece of code, we attach a generator to play prompts. The generator can, like all generators, be stopped at any time so that the agent (queue member) can get the call immediately.
The generator is now placed in app_queue, but could propably be moved somewhere else. It also changes functionality in main/say.c in order to be able to place those prompts in the same prompt queue for background processing. The same generator could be used to sevice conference bridges and maybe be added as a dialplan function at some point for background playlists.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Quite a lot of testing in our environment during the rather long time we've been testing this. Customer is happy.
There was some complaints from a bowl of petunias, which made me a bit surprised.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/19795">19795</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_queue.c <span style="color: grey">(364000)</span></li>
<li>/trunk/configs/queues.conf.sample <span style="color: grey">(364000)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(364000)</span></li>
<li>/trunk/include/asterisk/file.h <span style="color: grey">(364000)</span></li>
<li>/trunk/main/asterisk.dynamics <span style="color: grey">(364000)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(364000)</span></li>
<li>/trunk/main/say.c <span style="color: grey">(364000)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1887/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>