<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1880/">https://reviewboard.asterisk.org/r/1880/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 27th, 2012, 8:59 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1880/diff/1/?file=27512#file27512line20" style="color: black; font-weight: bold; text-decoration: underline;">/asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">exten => hangup,1,NoOp()</pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this extension actually used? Maybe you meant to use the 'h' extension?</pre>
</blockquote>
<p>On April 27th, 2012, 9:13 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nope. This extension is called to hang up the channel.
I think there's some confusion here as to what is going on. The set of extensions in [caller] are used to control a channel that feeds data into the ConfBridge application. This can be playing back a file, sending DTMF, waiting indefinitely (in the case where we aren't taking any actions), or hanging up. In this particular case, this extension hangs up this channel, mimicking a caller into ConfBridge hanging up.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should add that the set of extensions in [caller] are used by the confbridge.py module to control the 'caller' channel that is bridged with whatever channel is in the ConfBridge. You may want to reference that module (which was added when confbridge_nominal was added to the TestSuite) to see how those extensions are used.</pre>
<br />
<p>- Matt</p>
<br />
<p>On April 23rd, 2012, 8:27 p.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated April 23, 2012, 8:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds a test to the Asterisk Test Suite to verify the recording of conferences by ConfBridge. It checks three scenarios:
1) Setting the record_conference bridge setting using the CONFBRIDGE function and using the default file name provided by the ConfBridge application.
2) Setting the record_conference and record_file bridge settings using the CONFBRIDGE function.
3) Using a non-default bridge profile from the ConfBridge config file.
In each scenario, a local channel is placed into a ConfBridge and a sound file containing talking streamed into the ConfBridge. The channel is then hung up. After the conference has ended, a second local channel is connected to an extension that plays the recorded file into the BackgroundDetect application. If talking is detected in the sound file and all expected events were received during scenario execution, the scenario passes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/confbridge.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/confbridge.py <span style="color: grey">(3157)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_recording/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_recording/run-test <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/confbridge_recording/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/confbridge/tests.yaml <span style="color: grey">(3157)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1880/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>