<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1839/">https://reviewboard.asterisk.org/r/1839/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks correct. An identical change needs to be made to res_calendar_icalendar.c</pre>
<br />
<p>- Terry</p>
<br />
<p>On April 2nd, 2012, 9:58 a.m., schmidts wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers and Terry Wilson.</div>
<div>By schmidts.</div>
<p style="color: grey;"><i>Updated April 2, 2012, 9:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">using google calendar with timezone GMT+2 (like my local timezone) and caldav to get calendar events. And i recognize that the alarm time was allways 2 hours later than the start time. Start and end time was correct but the alarm was allways wrong, even when i changed the timezone.
by going through the code i found that this happens when the alarm is given as an offset to the start time.
Fix is very easy to not convert the alarm time to utc but instead use the timezone from the start time itself.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">before my patch i got this events:
Events
------
Summary :
Description :
Organizer :
Location :
Categories :
Priority : 0
UID : 3l14kh1vr2kpn55899u6q8pafo@google.com
Start : 2012-04-02 04:15:00 PM +0200
End : 2012-04-02 05:15:00 PM +0200
Alarm : 2012-04-02 06:12:00 PM +0200
and with my patch the same event looks like this:
Events
------
Summary :
Description :
Organizer :
Location :
Categories :
Priority : 0
UID : 3l14kh1vr2kpn55899u6q8pafo@google.com
Start : 2012-04-02 04:15:00 PM +0200
End : 2012-04-02 05:15:00 PM +0200
Alarm : 2012-04-02 04:12:00 PM +0200 </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/10/res/res_calendar_caldav.c <span style="color: grey">(358376)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>