<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1860/">https://reviewboard.asterisk.org/r/1860/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For Asterisk 10, there's not much choice here other than to do this so that things behave as expected.</pre>
<br />
<p>- Mark</p>
<br />
<p>On April 9th, 2012, 10:40 a.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers, irroot and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated April 9, 2012, 10:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Users were reporting a behavioral change in 10 from 1.8 invloving queues and the setting of 'ringinuse' not having any effect. Tracking this down revealed this to be caused by the ignorebusy setting defaulting to 0 in Asterisk 10 with its effects occuring when it was set to off.
This patch changes the default to 1 in Asterisk 10. Some additional changes are in progress for Trunk since we can do more with that. I assume the reason this slipped past irroot in the first place is because it was designed from the perspective of realtime queues.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested values at startup and made sure the ringinuse setting had an effect on queue member selection.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19536">ASTERISK-19536</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/10/CHANGES <span style="color: grey">(361654)</span></li>
<li>/branches/10/apps/app_queue.c <span style="color: grey">(361654)</span></li>
<li>/branches/10/configs/queues.conf.sample <span style="color: grey">(361654)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1860/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>