<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1796/">https://reviewboard.asterisk.org/r/1796/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 20th, 2012, 9:59 a.m., <b>Russell Bryant</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">How many cases are there where we *do* want a test to run on older versions, but not newer versions? That's the case where this change would be annoying. If there are very very few of them, I suppose it's not a big deal.</pre>
</blockquote>
<p>On March 20th, 2012, 10:02 a.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At the moment, zero. We have been making sure all tests run on trunk, regardless if a test is considered old.</pre>
</blockquote>
<p>On March 20th, 2012, 10:22 a.m., <b>opticron</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">So when we remove a deprecated feature from trunk for which there exists a test, do we remove that test?</pre>
</blockquote>
<p>On March 20th, 2012, 11:34 a.m., <b>Paul Belanger</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No sure, we haven't come across this situation yet. Something we have to consider, but don't think it will happen to often at the moment.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Given that we're going to be dropping 1.4 and 1.6.2 in the near future, only being able to skip individual branches is maintainable for the near term. I see this more as an augment to the minversion/maxversion rather than a replacement since min/maxversion deal with open-ended ranges while this skip functionality deals with individual branches. I don't remember if min/maxversion also handles down to the tag level, but if it does that would also be an issue.</pre>
<br />
<p>- opticron</p>
<br />
<p>On March 6th, 2012, 11:02 a.m., Paul Belanger wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Paul Belanger.</div>
<p style="color: grey;"><i>Updated March 6, 2012, 11:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm looking for some initial feedback on the following patch. Since we have the digiumphones branch now, we need to rework on the testsuite handles asterisk versions. Before we used minversion / maxversion (which worked across branches) however this does not work well if you have a parallel branch.
So, I've removed them in favour of 'skip'. Basically, the testsuite will run on every version of asterisk unless you have 'skip' defined, then depending on the flag (right now branch) it checks to run or skip the test.
We currently use the 'skip' flag, but only for a basic check. At the moment to skip broken tests, this new method would give us more control on the type of tests to skip. EG: Skip if OS is FreeBSD or skip if arch is i386.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local dev box.
There is also more work needed to be done in updating the test-config.yaml files, however I want to get this patch reviewed before making all those changes.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/lib/python/asterisk/TestConfig.py <span style="color: grey">(3083)</span></li>
<li>asterisk/trunk/lib/python/asterisk/version.py <span style="color: grey">(3083)</span></li>
<li>asterisk/trunk/runtests.py <span style="color: grey">(3083)</span></li>
<li>asterisk/trunk/tests/channels/SIP/message_auth/test-config.yaml <span style="color: grey">(3083)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>