<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1743/">https://reviewboard.asterisk.org/r/1743/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By junky.</div>
<p style="color: grey;"><i>Updated March 19, 2012, 7:09 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">After I changed what wdoekes proposed.
I also find another bad assignment+comparison.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is to prevent many more cppcheck warnings.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">used cppcheck 1.52
it compiles ;)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/res/res_odbc.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_phoneprov.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_musiconhold.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_format_attr_silk.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_http_post.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_jabber.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_format_attr_celt.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_config_sqlite3.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_corosync.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/asterisk.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/data.c <span style="color: grey">(357660)</span></li>
<li>trunk/res/res_config_ldap.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_groupcount.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_odbc.c <span style="color: grey">(357660)</span></li>
<li>trunk/main/ast_expr2.fl <span style="color: grey">(357660)</span></li>
<li>trunk/main/ast_expr2f.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_devstate.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_env.c <span style="color: grey">(357660)</span></li>
<li>trunk/funcs/func_callerid.c <span style="color: grey">(357660)</span></li>
<li>trunk/codecs/codec_resample.c <span style="color: grey">(357660)</span></li>
<li>trunk/formats/format_h264.c <span style="color: grey">(357660)</span></li>
<li>trunk/codecs/codec_dahdi.c <span style="color: grey">(357660)</span></li>
<li>trunk/codecs/codec_g726.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/vcodecs.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_unistim.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_sip.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_h323.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_gtalk.c <span style="color: grey">(357660)</span></li>
<li>trunk/apps/app_minivm.c <span style="color: grey">(357660)</span></li>
<li>trunk/apps/app_osplookup.c <span style="color: grey">(357660)</span></li>
<li>trunk/cdr/cdr_pgsql.c <span style="color: grey">(357660)</span></li>
<li>trunk/cdr/cdr_sqlite3_custom.c <span style="color: grey">(357660)</span></li>
<li>trunk/channels/chan_alsa.c <span style="color: grey">(357660)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1743/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>