<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1805/">https://reviewboard.asterisk.org/r/1805/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to me mostly. Just one minor concern to address below.</pre>
 <br />





<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://reviewboard.asterisk.org/r/1805/diff/2/?file=25921#file25921line1372" style="color: black; font-weight: bold; text-decoration: underline;">/branches/1.8/apps/app_dial.c</a>
    <span style="font-weight: normal;">

     (Diff revision 2)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static struct ast_channel *wait_for_answer(struct ast_channel *in,</pre></td>

  </tr>
 </tbody>



 
 




 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">1347</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                                        <span class="n">ast_indicate</span><span class="p">(</span><span class="n">in</span><span class="p">,</span> <span class="n">AST_CONTROL_HOLD</span><span class="p">);</span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1369</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">                                        <span class="n">ast_indicate<span class="hl">_data</span></span><span class="p">(</span><span class="n">in</span><span class="p">,</span> <span class="n">AST_CONTROL_HOLD</span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">f</span></span><span class="o"><span class="hl">-&gt;</span></span><span class="n"><span class="hl">data</span></span><span class="p"><span class="hl">.</span></span><span class="n"><span class="hl">ptr</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">f</span></span><span class="o"><span class="hl">-&gt;</span></span><span class="n"><span class="hl">datalen</span></span><span class="p">);</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this change made? Is there a circumstance where hold frames have data in them?</pre>
</div>
<br />



<p>- Mark</p>


<br />
<p>On March 8th, 2012, 12:24 p.m., rmudgett wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By rmudgett.</div>


<p style="color: grey;"><i>Updated March 8, 2012, 12:24 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Incoming calls that do not use ulaw will generate a bunch of warning messages and possibly fail when a DAHDI channel is then called if the Dial m or r options are used.

You get:
[Mar 6 20:39:05] WARNING[2994]: chan_dahdi.c:9061 dahdi_write: Cannot handle frames in g722 format
[Mar 6 20:39:05] WARNING[2994]: app_dial.c:1410 wait_for_answer: Unable to forward voice or dtmf

A bandaid patch was applied to silence the above warnings for each frame by setting up a translation path for future frames.  The bandaid patch also emits this warning:
Codec mismatch on channel %s setting write format to %s from %s native formats %s

This problem also occurs if the dial is forked to multiple destinations: Dial(DAHDI/1&amp;DAHDI/2)</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Without patch, the codecs are not setup when Dial options m or r are used and the SIP codec is not ulaw.

With the patch, the voice frames are not passed and the diagnostic messages are not generated.</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-16901">ASTERISK-16901</a>, 

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-17541">ASTERISK-17541</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/apps/app_dial.c <span style="color: grey">(358691)</span></li>

 <li>/branches/1.8/main/channel.c <span style="color: grey">(358691)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1805/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>