<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1786/">https://reviewboard.asterisk.org/r/1786/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 12th, 2012, 2:06 p.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You are missing the new channel_internal.h file in this diff.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well crap, I suppose I will re-write those changes...</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 12th, 2012, 2:06 p.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://reviewboard.asterisk.org/r/1786/diff/2/?file=26000#file26000line1175" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/main/channel_internal_api.c</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct ast_channel *ast_channel_internal_finalize(struct ast_channel *chan)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1173</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">struct</span> <span class="n">ast_channel</span> <span class="o">*</span><span class="nf">ast_channel_internal_finalize</span><span class="p">(</span><span class="k">struct</span> <span class="n">ast_channel</span> <span class="o">*</span><span class="n">chan</span><span class="p">)</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1174</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">{</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1175</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">chan</span><span class="o">-></span><span class="n">finalized</span> <span class="o">=</span> <span class="mi">1</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1176</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">chan</span><span class="p">;</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1177</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="p">}</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is a bit silly to have this function return anything since it is a setter function.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eh, it was convenient since the only place that would *ever* call this function is the channel alloc function just before return. If it makes you a happy camper, I'll make it void and add an extra line to the alloc function.</pre>
<br />
<p>- Terry</p>
<br />
<p>On March 9th, 2012, 3:54 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated March 9, 2012, 3:54 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should finish up the first stage of opaquification.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">unit tests pass. I think I ran the testsuite on it last night and it passed. I'm running it again right now just to make sure.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/main/channel.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_channelredirect.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_chanspy.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_confbridge.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_dial.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_disa.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_dumpchan.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_externalivr.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_followme.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_macro.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_mixmonitor.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_parkandannounce.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_queue.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_speech_utils.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_stack.c <span style="color: grey">(358725)</span></li>
<li>/trunk/apps/app_talkdetect.c <span style="color: grey">(358725)</span></li>
<li>/trunk/bridges/bridge_multiplexed.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_agent.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_bridge.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_phone.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_unistim.c <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/chan_vpb.cc <span style="color: grey">(358725)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(358725)</span></li>
<li>/trunk/include/asterisk/channel.h <span style="color: grey">(358725)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/file.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/indications.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/manager.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(358725)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(358725)</span></li>
<li>/trunk/res/res_agi.c <span style="color: grey">(358725)</span></li>
<li>/trunk/res/res_musiconhold.c <span style="color: grey">(358725)</span></li>
<li>/trunk/res/snmp/agent.c <span style="color: grey">(358725)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1786/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>